Saga wrapper and webchat bump #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2020 16:55
Signed-off-by: Srinaath Ravichandran <[email protected]> Handling saga errors Signed-off-by: Srinaath Ravichandran <[email protected]> Revert res.ok Signed-off-by: Srinaath Ravichandran <[email protected]> Track saga error Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
Signed-off-by: Srinaath Ravichandran <[email protected]>
tonyanziano
approved these changes
Mar 7, 2020
Comment on lines
+145
to
+161
| function* rootSaga() { | ||
| yield all( | ||
| applicationSagas.map(saga => | ||
| spawn(function*() { | ||
| while (true) { | ||
| try { | ||
| yield call(saga); | ||
| break; | ||
| } catch (error) { | ||
| console.error('Saga error: ', error); // eslint-disable-line | ||
| } | ||
| } | ||
| }) | ||
| ) | ||
| ); | ||
| } | ||
| sagaMiddleware.run(rootSaga); |
cwhitten
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles