[ISSUE#1909][MAS1.3.1][Screen Reader-Connect the bot] Voiceover announces the same name on the two control with different role #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denscollo
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
tonyanziano
suggested changes
Nov 27, 2019
| @@ -95,7 +103,7 @@ export class SplitButton extends React.Component<SplitButtonProps, SplitButtonSt | |||
| </button> | |||
| <div className={styles.separator} aria-hidden={'true'} /> | |||
| <button | |||
| aria-label={defaultLabel} | |||
| aria-label={auxiliaryLabel} | |||
There was a problem hiding this comment.
I think it's a good idea to make this default to the defaultLabel here in case auxiliaryLabel was not passed in.
aria-label={ auxiliaryLabel | defaultLabel }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1909
Description
Fixes how Voiceover announces the same name "Restart Conversation" for the "Restart conversation" button and "Restart conversation" dropdown.
Changes made
We added a new property to the SplitButton component named auxiliaryLabel. This label will add to the "Restart conversation" legend an extra "sub menu" legend to difference the button from the dropdown when the emulator runs under macOS.
This way, Voiceover will read the SplitButton with two different legends as NVDA does on Windows.
Testing
In the following recording, you can see how Voiceover reads the button and the dropdown with two different labels: