New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased ngrok spawn timeout to 15 seconds. #1998

Merged

tonyanziano merged 1 commit into master from toanzian/ngrok

Nov 20, 2019

Contributor

tonyanziano commented Nov 20, 2019 •

edited

Loading

Carrying over the fix for an issue that users were experiencing when trying to connect to remote bots on slower networks.

===

Users on faster networks should not notice any change, and users on slower networks should no longer be broken / intermittently broken.


          Increased ngrok spawn timeout to 15 seconds.

549dd0d

tonyanziano requested review from a-b-r-o-w-n, compulim, corinagum and cwhitten as code owners

November 20, 2019 22:30

coveralls commented Nov 20, 2019

Coverage remained the same at 68.529% when pulling 549dd0d on toanzian/ngrok into 660373c on master.

corinagum approved these changes

View reviewed changes

tonyanziano merged commit c2bee8b into master

tonyanziano deleted the toanzian/ngrok branch

November 20, 2019 23:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet