Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved focus indication in split button panel. #1992

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Improved focus indication in split button panel. #1992

merged 1 commit into from
Nov 18, 2019

Conversation

tonyanziano
Copy link
Contributor

#1912

===

Fixes HC theming for the split button panel, as well as improves focus indication inside the panel when using Dark / Light themes (added teal border).

Before:
split-hc-before

After:

split-hc-after

split-dark-after

split-light-after

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.55% when pulling ee2c61c on toanzian/split-contrast into 1f0e1e6 on master.

@tonyanziano tonyanziano merged commit b84c941 into master Nov 18, 2019
@tonyanziano tonyanziano deleted the toanzian/split-contrast branch November 18, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @corinagum