Fixed issue with duplicate native browser functions. #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/shortcut-fix
branch
from
80c06c5
to
4147655
Compare
compulim
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1893 I implemented functionality for native browser functions (cut, copy, paste, etc.) that were already functional inside of Chrome.
The implemented functionality didn't eat or stop the original event's native behavior, so actions like cut, copy, paste, were being fired twice instead of a single time. This was problematic when pasting credentials into the Open Bot dialog because they were duplicated if pasted into inputs with Ctrl+V, and thus were wrong when sent to the server.
Ex: myPassword --> Ctrl + V --> myPasswordmyPassword
I removed my implementation and will just leave the functionality up to the browser.