Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1793] Fixed focus order a11y issue with resources dialog. #1883

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

tonyanziano
Copy link
Contributor

#1793

===

Fixes focus order of Dialog controls while in browse mode so that it is aligned with how the dialog is laid out visually.

Previous order:

Dialog heading -> Close button -> Dialog content

New order:

Close button -> Dialog heading -> Dialog content

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.913% when pulling e7847ba on toanzian/acc-#1793 into e73b856 on master.

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyanziano tonyanziano merged commit 2eaf596 into master Sep 26, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1793 branch September 26, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants