Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to checkboxes to prevent doubling of text #1865

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Add aria-label to checkboxes to prevent doubling of text #1865

merged 4 commits into from
Sep 13, 2019
+9 −1

Conversation

corinagum
Copy link
Contributor

#1823

Checkboxes were previously reading the label twice. Adding aria-label prevents double reading of text.

@coveralls
Copy link

coveralls commented Sep 11, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 65.742% when pulling 0db801d on corinagum/1823 into b979700 on master.

tonyanziano
tonyanziano previously approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog entry

@tonyanziano tonyanziano merged commit 2743410 into master Sep 13, 2019
@tonyanziano tonyanziano deleted the corinagum/1823 branch September 13, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @coveralls @tonyanziano