Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#1819][MAS4.1.2] [Screen Reader-Debug] Screen reader is not reading the Name for “Previous and Next” arrow buttons #1841

Merged
merged 8 commits into from
Sep 6, 2019
Merged

[ISSUE#1819][MAS4.1.2] [Screen Reader-Debug] Screen reader is not reading the Name for “Previous and Next” arrow buttons #1841

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ff75b9
Add aria-label to left and right arrows buttons
Bill7zz Sep 5, 2019
300f51a
Update set Previous/Next instead of Left/Right
Bill7zz Sep 5, 2019
949322a
Remove extra spaces
Bill7zz Sep 5, 2019
aeb07c0
Merge branch 'master' into fix/screen-reader-arrow-buttons
denscollo Sep 5, 2019
28db7d1
Update changelog with solved issue
denscollo Sep 5, 2019
f5be479
Add iconSelected on prev and next buttons
denscollo Sep 6, 2019
49c6c76
Merge branch 'master' into fix/screen-reader-arrow-buttons
denscollo Sep 6, 2019
0bc6ee8
Merge branch 'master' into fix/screen-reader-arrow-buttons
denscollo Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1835](https://github.com/microsoft/BotFramework-Emulator/pull/1835)
- [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
- [1838](https://github.com/microsoft/BotFramework-Emulator/pull/1838)
- [1841](https://github.com/microsoft/BotFramework-Emulator/pull/1841)
- [1843](https://github.com/microsoft/BotFramework-Emulator/pull/1843)
- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)

- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)


## v4.5.2 - 2019 - 07 - 17
## Fixed
Expand Down
16 changes: 10 additions & 6 deletions packages/extensions/json/bf-extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,13 @@
"id": "leftArrow",
"states": {
"default": {
"icon": "leftArrow"
"icon": "leftArrow",
"aria-label": "Previous"
},
"selected": {
"aria-selected": true,
"icon": "leftArrowSelected"
"icon": "leftArrowSelected",
"aria-label": "Previous",
"aria-selected": true
},
"disabled": {
"aria-disabled": true
Expand All @@ -56,11 +58,13 @@
"id": "rightArrow",
"states": {
"default": {
"icon": "rightArrow"
"icon": "rightArrow",
"aria-label": "Next"
},
"selected": {
"aria-selected": true,
"icon": "rightArrowSelected"
tonyanziano marked this conversation as resolved.
Show resolved Hide resolved
"icon": "rightArrowSelected",
"aria-label": "Next",
"aria-selected": true
},
"disabled": {
"aria-disabled": true
Expand Down