Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1710] Fixed color contrast issues on welcome page. #1782

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Aug 27, 2019

#1710

===

Affected areas:

  • (Light / Dark) Version header
  • (Light) My bots list entries

Version header (Light)

light_header

My bots list entries (Light)

light_bots

Version header (Dark)

dark_header

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one comment

@@ -2,8 +2,8 @@
export const marginFix: string;
export const noBots: string;
export const recentBot: string;
export const recentBotPath: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, we don't want this in alphabetical order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why it got generated that way, but it's auto-generated

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.342% when pulling 6fdec75 on toanzian/acc-#1710 into 3dcbad5 on master.

@tonyanziano tonyanziano merged commit b58d796 into master Aug 27, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1710 branch August 27, 2019 18:57
@corinagum corinagum changed the title Fixed color contrast issues on welcome page. [#1710] Fixed color contrast issues on welcome page. Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants