Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input grouping semantics in app settings editor. #1776

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Aug 22, 2019

Addresses #1768

===

Inputs within each of the App Settings sections will now be prefaced by their respective headings when using a screen reader.

image

Ex: "Application Updates grouping. Automatically download and install updates checkbox unchecked."

@coveralls
Copy link

coveralls commented Aug 22, 2019

Coverage Status

Coverage remained the same at 65.342% when pulling f769bdd on toanzian/acc-#1768 into 997df8e on master.

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool - fieldset and legend are new for me

@tonyanziano
Copy link
Contributor Author

@corinagum same. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants