Fixed handling of attachments sent from a bot. #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
justinwilaby
as code owners
tonyanziano
force-pushed
the
toanzian/#1362-attachments
branch
from
4939199
to
fdd90b3
Compare
justinwilaby
previously approved these changes
Jun 27, 2019
tonyanziano
force-pushed
the
toanzian/#1362-attachments
branch
from
fdd90b3
to
8a1d7c5
Compare
justinwilaby
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362
===
The issue was that the attachment data sent from a bot is already an encoded base64 string, and is not a buffer that needs to be converted, whereas attachments uploaded via the Web Chat client's paperclip button arrive as a buffer that needs to be converted.
The latter case was fixed in #1364.
This will fix the former case.
Uploading image from bot code:
Uploading image from Web Chat client control: