Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwilaby/#1523 slider fix #1546

Merged
merged 6 commits into from
May 8, 2019
Merged

Jwilaby/#1523 slider fix #1546

merged 6 commits into from
May 8, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented May 8, 2019

Fixes #1513 This PR fixes the slider issue without compromising functionality. It also "property" sets up the mousemove system of events.

tonyanziano
tonyanziano previously approved these changes May 8, 2019
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe add a changelog entry?

justinwilaby added a commit that referenced this pull request May 8, 2019
justinwilaby added a commit that referenced this pull request May 8, 2019
tonyanziano
tonyanziano previously approved these changes May 8, 2019
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@justinwilaby justinwilaby merged commit 350d8bf into master May 8, 2019
@justinwilaby justinwilaby deleted the jwilaby/#1523-slider-fix branch May 8, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidecar window slider gets stuck in 'slide' mode
2 participants