Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tomlm/create conversation #1233

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Tomlm/create conversation #1233

merged 3 commits into from
Jan 16, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Jan 16, 2019 •
edited
Loading

This PR fixes #1234 by removing checks for the members param in calls to the v3/conversation api in order to allow the emulation of proactive messaging when bot initiated conversations are required.

@coveralls
Copy link

coveralls commented Jan 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1804

  • 6 of 7 (85.71%) changed or added relevant lines in 3 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 61.405%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/restServer.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
packages/emulator/core/lib/conversations/middleware/errorCondition/createConversationValidator.js 4 54.05%
packages/emulator/core/lib/conversations/middleware/createConversation.js 16 19.61%
Totals Coverage Status
Change from base Build 1800: 0.006%
Covered Lines: 5418
Relevant Lines: 7904
💛 - Coveralls

tonyanziano
tonyanziano reviewed Jan 16, 2019
View reviewed changes
...ges/emulator/core/src/conversations/middleware/errorCondition/createConversationValidator.ts Outdated
if (!endpoint) {
return CreateConversationError.APP_ID_MISSING;
}
}

export { CreateConversationError, validateCreateConversationRequest };

// tslint:disable-next-line:no-consecutive-blank-lines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was an issue due to auto formatting on Tom's machine, but can this be removed?

tonyanziano
tonyanziano approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@justinwilaby justinwilaby merged commit 0f2e107 into master Jan 16, 2019
@justinwilaby justinwilaby deleted the tomlm/CreateConversation branch January 16, 2019 19:06
a-b-r-o-w-n
a-b-r-o-w-n reviewed Jan 16, 2019
View reviewed changes
CONTRIBUTING.md
@@ -40,7 +40,7 @@ cd BotFramework-Emulator
> npm version 5.6.0 or greater is required.

```
npm i -g [email protected] [email protected] jest
npm i -g [email protected] [email protected] webpack-cli jest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why these dependencies need to be globally installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinwilaby ?

This was referenced Nov 5, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@tonyanziano tonyanziano tonyanziano approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Checks for members on the Create Conversation API
4 participants
@justinwilaby @coveralls @tonyanziano @a-b-r-o-w-n