Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade webchat to v4 #1219

Merged
merged 30 commits into from
Jan 17, 2019
Merged

upgrade webchat to v4 #1219

merged 30 commits into from
Jan 17, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 9, 2019 •
edited
Loading

Todo:

  • Speech - getting a 401 after sending a stt message from the bing api. working with Andrea to update the token the emulator uses to authenticate to bing.
  • Themes -- will submit another PR with adaptive cards theme fixes
  • Clean up any v3 related code / styles
  • a11y -- parity with released version, can discuss additions to UX
  • Specs

@coveralls
Copy link

coveralls commented Jan 9, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1824

  • 47 of 57 (82.46%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 61.835%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/parts/log/logEntry.tsx 0 4 0.0%
packages/app/client/src/ui/editor/emulator/parts/log/log.tsx 1 7 14.29%
Totals Coverage Status
Change from base Build 1813: 0.4%
Covered Lines: 5468
Relevant Lines: 7930
💛 - Coveralls

justinwilaby
justinwilaby suggested changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests for the new functionality in this PR. Please include unit tests for the new functionality.
e.g. activityWrapper.tsx, chat.tsx, emulator.tsx and chatPanel.tsx are all missing unit tests.

packages/app/client/src/ui/editor/emulator/chatPanel/chatPanel.tsx Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/chatPanel/chatPanel.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/chatPanel/chatPanel.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.tsx Outdated Show resolved Hide resolved
@justinwilaby
Copy link
Contributor

Unit test is failing. FAIL packages/app/client/src/ui/editor/emulator/parts/chat/chat.spec.ts

justinwilaby
justinwilaby previously requested changes Jan 9, 2019
View reviewed changes
packages/app/client/src/ui/styles/themes/dark.css Outdated Show resolved Hide resolved
packages/app/client/src/ui/styles/themes/dark.css Outdated Show resolved Hide resolved
@justinwilaby justinwilaby dismissed their stale review January 9, 2019 21:42

Noticed this is a WIP.

compulim
compulim reviewed Jan 10, 2019
View reviewed changes
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/activityWrapper.tsx Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.scss Outdated Show resolved Hide resolved
packages/app/client/src/ui/editor/emulator/parts/chat/chat.tsx Outdated Show resolved Hide resolved
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Jan 14, 2019
Closed
@a-b-r-o-w-n a-b-r-o-w-n changed the title [wip] upgrade webchat to v4 upgrade webchat to v4 Jan 15, 2019
@a-b-r-o-w-n
Copy link
Contributor Author

a-b-r-o-w-n commented Jan 15, 2019 •
edited
Loading

With regards to the adaptive cards styling, I am going to work on a follow-up PR that addresses that in #1231

cwhitten
cwhitten previously approved these changes Jan 17, 2019
View reviewed changes
@cwhitten
Copy link
Member

This needs a rebase, and would conflict heavily with the prettier branch. Because we still have tests to run on prettier we should land this first.

@a-b-r-o-w-n
add themes for webchat
9ddddd9
@a-b-r-o-w-n
update to webchat master
d43c220
@a-b-r-o-w-n
relax return type of setState
87158d9
@a-b-r-o-w-n
fix webchat UI issue due to box-sizing
68c1c15
@a-b-r-o-w-n
[a11y] add role of button to activity wrapper
6fca154
@a-b-r-o-w-n
improve activity selection
588fdfb 
Do not inspect the activity when interacting with an interactive element
on the card.
@a-b-r-o-w-n
add activityWrapper tests
7d10eb4
@a-b-r-o-w-n
bump to latest web chat
a2b0bf2 
enables styling the send box
@a-b-r-o-w-n
expand webchat theme
de00f84
@a-b-r-o-w-n
add tests for chat.tsx
5246f0c
@a-b-r-o-w-n
add copyright
d696404
@a-b-r-o-w-n
chat panel tests
8f6549a
@a-b-r-o-w-n
enable speech recognition
e38449e 
TODO: after sending a speech-to-text message,
a request is made to a bing endpoint which results in a 401.
I am working to get that resolved.
@a-b-r-o-w-n
improve transcript overlays high contrast theme
3d1e29f
@a-b-r-o-w-n
improve focus state UI
24fdc1b
@a-b-r-o-w-n
remove v3 styles
58ed329
@a-b-r-o-w-n
do not show send box when in transcript mode
67bda8f
@a-b-r-o-w-n
use theme colors when connecting to bot
cbe51cc
@a-b-r-o-w-n
rename method for clarity
1cb6556
@a-b-r-o-w-n
add missing semicolon
2c6f4e9
@a-b-r-o-w-n
fix typo
a549c94
@a-b-r-o-w-n a-b-r-o-w-n merged commit 6b53181 into master Jan 17, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the upgrade-webchat branch January 17, 2019 16:39
@corinagum
Copy link
Contributor

🍾

This was referenced Jan 17, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby left review comments

@compulim compulim compulim left review comments

@cwhitten cwhitten cwhitten approved these changes

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@a-b-r-o-w-n @coveralls @justinwilaby @cwhitten @corinagum @compulim