Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53.teams-messaging-extensions-action-preview]: Sample enhancement for adding user attribution for bot messages JavaScript/NodeJs #3050

Merged
merged 13 commits into from
Feb 3, 2021

Conversation

Trinetra-MSFT
Copy link
Contributor

@Trinetra-MSFT Trinetra-MSFT commented Jan 25, 2021

Description:

In scenarios where a bot sends messages on behalf of a user, attributing the message to that user can help with engagement and showcase a more natural interaction flow. This feature allows you to attribute a message from your bot to a user on whose behalf it was sent.

Proposed Changes

  • Added code snippet in the existing sample for user attribution Node JS
  • Updated ReadMe file

Testing

  1. Click on Create card command
  2. Fill the task module adaptive card
  3. Set send card in channel on behalf of user

image

Preview:
image

card in channel with user attribution:
image

On Behalf of set to false:
image

image

Card in channel:
image

Added user attribution code in exisiting sample
@Trinetra-MSFT Trinetra-MSFT requested a review from a team as a code owner January 25, 2021 10:20
@Wajeed-msft Wajeed-msft requested a review from clearab January 28, 2021 15:56
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor grammar and style suggestions, mostly.

@Trinetra-MSFT
Copy link
Contributor Author

Thanks @mdrichardson , I will look into review comments and close it today

Trinetra-MSFT and others added 3 commits February 2, 2021 11:47
Co-authored-by: Michael Richardson <[email protected]>
…-preview/adaptiveCardHelper.js

Co-authored-by: Michael Richardson <[email protected]>
…-preview/bots/teamsMessagingExtensionsActionPreviewBot.js

Co-authored-by: Michael Richardson <[email protected]>
This reverts commit 2a61007.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants