-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[53.teams-messaging-extensions-action-preview]: Sample enhancement for adding user attribution for bot messages JavaScript/NodeJs #3050
Merged
EricDahlvang
merged 13 commits into
microsoft:main
from
Trinetra-MSFT:v-trkum/MEUserAttributionPreview
Feb 3, 2021
Merged
[53.teams-messaging-extensions-action-preview]: Sample enhancement for adding user attribution for bot messages JavaScript/NodeJs #3050
EricDahlvang
merged 13 commits into
microsoft:main
from
Trinetra-MSFT:v-trkum/MEUserAttributionPreview
Feb 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added user attribution code in exisiting sample
mdrichardson
suggested changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor grammar and style suggestions, mostly.
samples/csharp_dotnetcore/53.teams-messaging-extensions-action-preview/README.md
Outdated
Show resolved
Hide resolved
samples/javascript_nodejs/53.teams-messaging-extensions-action-preview/adaptiveCardHelper.js
Outdated
Show resolved
Hide resolved
samples/javascript_nodejs/53.teams-messaging-extensions-action-preview/adaptiveCardHelper.js
Outdated
Show resolved
Hide resolved
samples/javascript_nodejs/53.teams-messaging-extensions-action-preview/adaptiveCardHelper.js
Outdated
Show resolved
Hide resolved
...3.teams-messaging-extensions-action-preview/bots/teamsMessagingExtensionsActionPreviewBot.js
Outdated
Show resolved
Hide resolved
Thanks @mdrichardson , I will look into review comments and close it today |
Co-authored-by: Michael Richardson <[email protected]>
…-preview/adaptiveCardHelper.js Co-authored-by: Michael Richardson <[email protected]>
…-preview/bots/teamsMessagingExtensionsActionPreviewBot.js Co-authored-by: Michael Richardson <[email protected]>
Done Co-authored-by: Michael Richardson <[email protected]>
…/Trinetra-MSFT/BotBuilder-Samples into v-trkum/MEUserAttributionPreview
mdrichardson
approved these changes
Feb 2, 2021
This reverts commit 2a61007.
EricDahlvang
approved these changes
Feb 3, 2021
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In scenarios where a bot sends messages on behalf of a user, attributing the message to that user can help with engagement and showcase a more natural interaction flow. This feature allows you to attribute a message from your bot to a user on whose behalf it was sent.
Proposed Changes
Testing
Preview:
card in channel with user attribution:
On Behalf of set to false:
Card in channel: