Move to latest versions of SDK #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add templates to package.
tomlm
reviewed
May 12, 2020
| @@ -5,15 +5,17 @@ | |||
| "author": "Microsoft", | |||
| "bugs": "https://github.com/Microsoft/BotBuilder-Samples/issues", | |||
| "dependencies": { | |||
| "@microsoft/bf-cli-command": "^4.8.0", | |||
| "@microsoft/bf-cli-command": "^4.9.0-RC6", | |||
| "@microsoft/bf-lu": "^4.10.0-preview.130225", | |||
There was a problem hiding this comment.
"^4.10.0-preview.130225", [](start = 24, length = 25)
this doesn't seem right. #Resolved
There was a problem hiding this comment.
tomlm
reviewed
May 12, 2020
| @@ -5,15 +5,17 @@ | |||
| "author": "Microsoft", | |||
| "bugs": "https://github.com/Microsoft/BotBuilder-Samples/issues", | |||
| "dependencies": { | |||
| "@microsoft/bf-cli-command": "^4.8.0", | |||
| "@microsoft/bf-cli-command": "^4.9.0-RC6", | |||
There was a problem hiding this comment.
", [](start = 44, length = 2)
this is no rc42? #Resolved
tomlm
reviewed
May 12, 2020
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| # template | |||
| - ``` | |||
| # booleanEntity(value) | |||
| ${'#'} booleanEntity(value) | |||
There was a problem hiding this comment.
${'#' [](start = 0, length = 5)
what the wha?
#Resolved
There was a problem hiding this comment.
Bug in LG that they are working on fixing and this is the work-around until they do.
In reply to: 423898362 [](ancestors = 423898362)
tomlm
reviewed
May 12, 2020
|
|
||
| # ValueTemplate | ||
| - ``` | ||
| # ${property}(values) | ||
| ${'#'} ${property}(values) |
There was a problem hiding this comment.
${'#'} [](start = 0, length = 7)
can you # ? #Resolved
There was a problem hiding this comment.
tomlm
reviewed
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest SDK packages including bug fixes to LG and LU.
For LG, allow # in multi-line.
For LU, set line numbers for entities.