Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code excerpts in README.md files #201

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

sphanley
Copy link
Contributor

@sphanley sphanley commented Oct 11, 2017

This change updates code samples in README.md files:

  • Update the README.md of the core-CreateNewComversation sample to reflect changes made in the SurveyTriggerer.cs. The current version of SurveyTriggerer.cs uses IDialogTask instead of IDialogStack, and additionally, the original version contained a typo on line 53: IDialogStack stack = stack = scope.Resolve<IDialogStack>();

  • Update the README.md of the core-CustomState sample to reflect changes in the Global.asax.cs. This code excerpt is updated to use Conversation.UpdateContainer rather than builder.Update(Conversation.Container) which is obsolete.

This change updates the README.md of the core-CreateNewComversation sample to reflect changes made in the SurveyTriggerer.cs. The current version of SurveyTriggerer.cs uses IDialogTask instead of IDialogStack, and additionally, the original version contained a typo on line 53: `IDialogStack stack = stack = scope.Resolve<IDialogStack>();`
Update code featured in README.md to match what's actually currently in the sample
@sphanley sphanley changed the title Update README.md in core-CreateNewConversation sample Update code samples in README.md files Oct 11, 2017
@sphanley sphanley changed the title Update code samples in README.md files Update code excerpts in README.md files Oct 11, 2017
@JasonSowers JasonSowers merged commit ed008de into microsoft:master Feb 16, 2018
@JasonSowers
Copy link
Contributor

Thank you for your contributions, sorry for the extended delay.

ckkashyap pushed a commit that referenced this pull request Oct 17, 2018
* Update README.md

This change updates the README.md of the core-CreateNewComversation sample to reflect changes made in the SurveyTriggerer.cs. The current version of SurveyTriggerer.cs uses IDialogTask instead of IDialogStack, and additionally, the original version contained a typo on line 53: `IDialogStack stack = stack = scope.Resolve<IDialogStack>();`

* Update README.md

Update code featured in README.md to match what's actually currently in the sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants