[Teams] Link unfurling sample updates (dotnet) #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtual-Josh
approved these changes
Nov 1, 2019
| // Send a message to the user | ||
| await turnContext.SendActivityAsync("The bot encounted an error or bug."); | ||
| await turnContext.SendActivityAsync("To continue to run this bot, please fix the bot source code."); | ||
| // Note: Since this Messaging Extension does not have the messageTeamMembers permission |
There was a problem hiding this comment.
This is an open question. Do we want to cut out the commented out lines of this sample? I'm not opposed to having them, but it looks to be inconsistent with other samples.
The TeamsMessagingExtensionSearch has the lines in, but doesn't have the messageTeamMembers permission in the manifest.
The TeamsMessagingExtensionAction has the lines commented out, but also does not have the permission in the manifest.
johnataylor
approved these changes
Nov 1, 2019
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove messaging (since this is a Messaging Extension that does not send messages)
Remove Bot from manifest
Add deployment templates
Update readme