Fixes 1218: Welcome Card does not display on non-Windows environments

[sgellock]

Fixes #1218

Proposed Changes

• use Path.Combine to build file path to welcomeCard.json

Testing

Build and run on macOS
Should see a welcome card as soon as Emulator connects to the Bot

[EricDahlvang]

@sgellock What is this? A comment explaining why this is necessary would be good here. (this is weird)

[sgellock]

You simply can’t use file paths because the world run on more than just Windows these days. On Feb 11, 2019, at 8:25 PM, Eric Dahlvang <[email protected]<mailto:[email protected]>> wrote: @EricDahlvang commented on this pull request.

________________________________ In samples/csharp_dotnetcore/13.basic-bot/BasicBot.cs<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FBotBuilder-Samples%2Fpull%2F1223%23discussion_r255798810&data=02%7C01%7Cscott.gellock%40microsoft.com%7C5f09d277a5ea45b68f4308d690a22ba5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636855423524313753&sdata=1Dcyl1%2BALQBLVLshCer2dq4OsdBwolhF8I5gpVd6jz8%3D&reserved=0>:

@@ -210,7 +210,9 @@ private Activity CreateResponse(Activity activity, Attachment attachment)

// Load attachment from file. private Attachment CreateAdaptiveCardAttachment() { - var adaptiveCard = File.ReadAllText(@".\Dialogs\Welcome\Resources\welcomeCard.json"); + string[] paths = {".", "Dialogs", "Welcome", "Resources", "welcomeCard.json"}; @sgellock<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsgellock&data=02%7C01%7Cscott.gellock%40microsoft.com%7C5f09d277a5ea45b68f4308d690a22ba5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636855423524323749&sdata=xM8kaRDcKWLcZzn33wTOoY6gVhqFE%2FLWaGmSQBhOWWg%3D&reserved=0> What is this? A comment explaining why this is necessary would be good here. (this is weird) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FBotBuilder-Samples%2Fpull%2F1223%23pullrequestreview-202479846&data=02%7C01%7Cscott.gellock%40microsoft.com%7C5f09d277a5ea45b68f4308d690a22ba5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636855423524323749&sdata=WbMUAE%2B8vDy0F7mESoC9QGD5zVi6k3%2B3P5uMn3rcvNw%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAsxdy_rsNitueqAsHO0fNSUF5pvF3jpks5vMkJOgaJpZM4a1fif&data=02%7C01%7Cscott.gellock%40microsoft.com%7C5f09d277a5ea45b68f4308d690a22ba5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636855423524323749&sdata=EbrLkZZ7prAE8dO7fDfDpNJ0QLdDlxyND4ZnBiMeTqk%3D&reserved=0>.

[EricDahlvang]

Windows + Azure.

[sgellock]

I don't understand your comment. You can't simply hard code file paths in source code that is expected to run on OS's other than windows. e.g. macOS for local development, Linux distros for deployment. The code as is simply doesn't run on non-windows OSs. what additional information do you need to understand the code change?

[EricDahlvang]

Sorry, my 'Windows + Azure' comment was facetious.

In seriousness, I've just never seen the syntax here. A requirement of concatenating folder names to retrieve a file at run-time. Maybe I'm just ignorant of this required method of cross-platform path resolution and it will be obvious to more informed developers.

[sgellock]

https://docs.microsoft.com/en-us/dotnet/api/system.io.path.combine?view=netframework-4.7.2

[EricDahlvang]

Thanks Scott. Apparently, I'm not keeping up well enough with the cross-platform world. :/

Here's a PR for some of the other samples:
@sgellock #1224