Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SendAttachment samples should illustrate upload and base64 data URIs #55

Closed
dandriscoll opened this issue Jan 18, 2017 · 3 comments
Closed

SendAttachment samples should illustrate upload and base64 data URIs #55

dandriscoll opened this issue Jan 18, 2017 · 3 comments

Comments

@dandriscoll
Copy link
Member

https://github.com/Microsoft/BotBuilder-Samples/tree/master/Node/core-SendAttachment
https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/core-SendAttachment

These samples do a good job on the attachment side, but don't illustrate upload.

They should show:

  1. Uploading via the attachment API (https://docs.botframework.com/en-us/restapi/connector/#!/Conversations/Conversations_UploadAttachment)
  2. Including an attachment inline as a base64 data URI (example here, search for "base64": https://docs.botframework.com/en-us/core-concepts/attachments/)
@dandriscoll dandriscoll mentioned this issue Jan 20, 2017
Closed
@ejadib
Copy link
Contributor

ejadib commented Jan 23, 2017 •
edited
Loading

Thanks @dandriscoll. We are applying these enhancements and they will be ready to be reviewed later today.

@ejadib ejadib mentioned this issue Jan 23, 2017
Merged
@pcostantini pcostantini mentioned this issue Jan 23, 2017
Merged
@ejadib
Copy link
Contributor

ejadib commented Jan 26, 2017

@dandriscoll this is already merged. Feel free to close the issue if the updates are ok for you.

@dandriscoll
Copy link
Member Author

These are great! Thanks @ejadib and @pcostantini

RobStand pushed a commit that referenced this issue May 11, 2017
@ejadib @RobStand
Update documentation links to point to new docs (#118)
6b3df2c 
* [C#-RichCards] Update image link pointing to old documentation

* [C#-SendAttachments] Update image link pointing to old documentation

* [C#-DirectLine] Update image link pointing to old documentation

* [C#-DirectLineWebSockets] Update image link pointing to old documentation

* [C#-CardsAttachments] Update links pointing to old doc (#55)

* [C#-CardsAttachment] Update image link pointing to old doc in AnimationCardScorable

* [C#-CardsAttachment] Update image link pointing to old doc in CarouselCardsScorable

* [C#-CardsAttachments] Update link pointing to old doc in HeroCardScorable

* [C#-CardsAttachments] Update link pointing to old doc in ThumbnaildCardScorable

* [Node-DirectLine] Update image link pointing to old documentation

* [Node-DirectLineWebSockets] Update image link pointing to old documentation

* [Node-RichCards] Update links pointing to old doc

* [Node-SendAttachment] Update image link pointing to old documentation

* [C#-CardsAttachments] Update links pointing to old links in assets (#56)

* [C#-CardsAttachments] Update links pointing to old doc in CSharpCode.xml

* [C#-CardsAttachments] Update links pointing to old docs in NodeJsCode.xml

* [C#] Update links on some leftover files

* [C#] Update documentation links to point to new docs in C# samples READMEs

* [Node] Update documentation links to point to new docs in Node samples READMEs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejadib @dandriscoll