Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in the readme of sample .../javascript_es6/01.browser-echo #1751

Closed
WashingtonKayaker opened this issue Sep 6, 2019 · 1 comment · Fixed by #1753
Closed

Broken links in the readme of sample .../javascript_es6/01.browser-echo #1751

WashingtonKayaker opened this issue Sep 6, 2019 · 1 comment · Fixed by #1753
Assignees
@v-kydela

Comments

@WashingtonKayaker
Copy link
Contributor

There appears to be broken links in the 01.browser-echo sample app readme, in the very first section titled 'browser echo sample' that is pointing to WebChatAdapter:

https://github.com/microsoft/BotBuilder-Samples/blob/master/src/webChatAdapter.js

And another broken link pointing to WebChatAdapter in the section titled 'Adapters' (The last 2 letters should be ts, not js):

https://github.com/microsoft/BotBuilder-Samples/blob/master/samples/javascript_es6/01.browser-echo/src/WebChatAdapter.js

I believe that those links should be:

https://github.com/microsoft/BotBuilder-Samples/blob/master/samples/javascript_es6/01.browser-echo/src/webChatAdapter.ts
v-kydela pushed a commit that referenced this issue Sep 9, 2019
Fix broken links in 01.browser-echo readme
f732dae 
Fixes #1751
@v-kydela v-kydela mentioned this issue Sep 9, 2019
Merged
@v-kydela
Copy link
Contributor

v-kydela commented Sep 9, 2019

Thank you, @WashingtonKayaker

I have submitted a pull request

sgellock pushed a commit that referenced this issue Sep 9, 2019
@sgellock
Fix broken links in 01.browser-echo readme (#1753)
61f9ad2 
Fixes #1751
This was referenced Jul 18, 2020
Open
Open
This was referenced Sep 22, 2022
Open
Open
Open
@garfbradaz garfbradaz mentioned this issue Sep 22, 2022
Open
This was referenced Sep 22, 2022
Open
Open
@garfbradaz garfbradaz mentioned this issue Sep 22, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 22, 2022
Open
This was referenced Sep 22, 2022
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 22, 2022
Open
This was referenced Sep 22, 2022
Open
Open
Open
Open
Open
This was referenced Sep 22, 2022
Open
Open
This was referenced Jan 10, 2023
Open
Open
Open
Open
This was referenced Jan 10, 2023
Open
Open
Open
@sssingh91 sssingh91 mentioned this issue Jan 10, 2023
Open
@garfbradaz garfbradaz mentioned this issue Jan 10, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jan 10, 2023
Open
@garfbradaz garfbradaz mentioned this issue Jan 10, 2023
Open
This was referenced Jan 10, 2023
Open
Open
Open
@garfbradaz garfbradaz mentioned this issue Jan 10, 2023
Open
@sssingh91 sssingh91 mentioned this issue Jan 10, 2023
Open
@garfbradaz garfbradaz mentioned this issue Jan 10, 2023
Open
@sssingh91 sssingh91 mentioned this issue Jan 10, 2023
Open
@garfbradaz garfbradaz mentioned this issue Jan 10, 2023
Open
@sssingh91 sssingh91 mentioned this issue Jan 10, 2023
Open
This was referenced Jan 10, 2023
Open
Open
This was referenced Jan 10, 2023
Open
Open
This was referenced Jan 10, 2023
Open
Open
This was referenced Jan 10, 2023
Open
Open
@garfbradaz garfbradaz mentioned this issue Jan 10, 2023
Open
@sssingh91 sssingh91 mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-kydela v-kydela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken links in 01.browser-echo readme microsoft/BotBuilder-Samples
2 participants
@v-kydela @WashingtonKayaker