Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do we have 2 'Samples' repos? #1199

Closed
brandonh-msft opened this issue Feb 4, 2019 · 3 comments
Closed

Why do we have 2 'Samples' repos? #1199

brandonh-msft opened this issue Feb 4, 2019 · 3 comments
Assignees
@Kaiqb
Labels
P1 Painful if we don't fix, won't block releasing

Comments

@brandonh-msft
Copy link
Contributor

brandonh-msft commented Feb 4, 2019 •
edited
Loading

It's confusing to users which Samples repo they should be looking at. Additionally our docs seem to reference some samples in this repo, and some samples in the BotFramework-Samples repo; we should consolidate these.

I've filed a similar issue on the BotFramework repo here.
@sgellock sgellock added Approved P1 Painful if we don't fix, won't block releasing labels Feb 5, 2019
@sgellock
Copy link
Member

sgellock commented Feb 5, 2019

@Kaiqb we should retire gh/ms/botframework-samples.

@Kaiqb
Copy link
Contributor

Kaiqb commented Feb 7, 2019

That's is the plan. We want to merge everything into botbuilder-samples repo.

@Kaiqb Kaiqb closed this as completed Feb 7, 2019
@Kaiqb Kaiqb reopened this Feb 7, 2019
@Kaiqb
Copy link
Contributor

Kaiqb commented Apr 2, 2019

All samples are now in the same "botbuilder-samples" repo. The change will go live in next 10 days.

@Kaiqb Kaiqb closed this as completed Apr 2, 2019
@snyk-bot snyk-bot mentioned this issue Mar 30, 2021
Closed
This was referenced Sep 15, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 16, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 31, 2021
Open
This was referenced Jun 20, 2023
Open
Open
Open
Open
This was referenced Dec 1, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kaiqb Kaiqb

Labels
P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgellock @brandonh-msft @Kaiqb