Skip to content

Commit

Permalink
Fixes 1246, EmptyBot missing appID and appPassword from Adapter const…
Browse files Browse the repository at this point in the history
…ructor (#1249)

- add appId and appPassword pulling from process.env
- update JavaScript
- update TypeScript
- bump version patch number
  • Loading branch information
sgellock authored Feb 16, 2019
1 parent d81bc1c commit ddb7998
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ server.listen(process.env.port || process.env.PORT || 3978, () => {

// Create adapter.
// See https://aka.ms/about-bot-adapter to learn more about .bot file its use and bot configuration.
const adapter = new BotFrameworkAdapter();
const adapter = new BotFrameworkAdapter({
appId: process.env.microsoftAppID,
appPassword: process.env.microsoftAppPassword
});

// Catch-all for errors.
adapter.onTurnError = async (context, error) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ server.listen(process.env.port || process.env.PORT || 3978, () => {

// Create adapter.
// See https://aka.ms/about-bot-adapter to learn more about .bot file its use and bot configuration.
const adapter = new BotFrameworkAdapter();
const adapter = new BotFrameworkAdapter({
appId: process.env.microsoftAppID,
appPassword: process.env.microsoftAppPassword
});

// Catch-all for errors.
adapter.onTurnError = async (context, error) => {
Expand Down
2 changes: 1 addition & 1 deletion generators/generator-botbuilder/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "generator-botbuilder",
"version": "4.2.5",
"version": "4.2.6",
"description": "A yeoman generator for creating bots using Bot Framework v4",
"homepage": "https://github.com/Microsoft/BotBuilder-Samples/tree/master/generators/generator-botbuilder",
"author": {
Expand Down

0 comments on commit ddb7998

Please sign in to comment.