Right-clicking table entities for delete selects two rows

[cliffeby]

Storage Explorer Version: 1.10.1
Build Number: 201990919.2
Platform/OS: Windows 10?
Architecture: x64?
Regression From: no

Bug Description

When you right click to delete a table row, the selected and the mouse located rowsare highlighted. Confirming the delete only removes the initially selected row as it should, but the warning message with two rows identified is misleading.

Steps to Reproduce

1. Right click any row in a table and select delete

Expected Experience

highlight only one selected row or use a bold color for the selected row.

Actual Experience

Additional Context

[JasonYeMSFT]

Could you please give more detailed steps to reproduce the bug?

[cliffeby]

Sorry had these details in html comments.

[cliffeby]

Replied on GitHub

…

On Mon, Oct 21, 2019 at 12:43 PM JasonYeMSFT ***@***.***> wrote: Could you please give more detailed steps to reproduce the bug? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2107?email_source=notifications&email_token=AAK5TPWPTMAXRCIMDGG2EXLQPXL3DA5CNFSM4JB6EB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB27TRI#issuecomment-544602565>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAK5TPRKVMGZWSUJT35OEULQPXL3DANCNFSM4JB6EB6Q> .

[JasonYeMSFT]

Could you please attach a screenshot or a recording showing the bug you are describing? We are having trouble reproducing this issue.

[cliffeby]

See attached screenshot

…

On Tue, Nov 5, 2019 at 5:09 PM JasonYeMSFT ***@***.***> wrote: Could you please attach a screenshot or a recording showing the bug you are describing? We are having trouble reproducing this issue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2107?email_source=notifications&email_token=AAK5TPVZAKBHKSW5KPUVAOTQSHVINA5CNFSM4JB6EB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDEQKGA#issuecomment-550044952>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAK5TPSUNFWXNMS7N6M2YCLQSHVINANCNFSM4JB6EB6Q> .

[MRayermannMSFT]

We don't see a screenshot. You need to paste it directly into your github comment. Attaching it to your email reply won't work.

[cliffeby]

Hope this works

https://1drv.ms/u/s!AgsEoWikEEW_le19RToQG0_G0_syyw?e=ulfXsF

[MRayermannMSFT]

Thanks. We understand the issue and will look into getting this fixed.

[craxal]

Unable to reproduce this issue on 1.14.2. When I try right-clicking an item different than the current selection, the current selection is set to that item as expected.

@cliffeby Can you reproduce on the latest version (1.14.2) of Storage Explorer?

@v-xianya Can you try reproducing this issue as well?

[cliffeby]

I still get the same behavior but less consistently. About half the time only one line is highlighted. When only one line is highlighted and then deleted, a new cell is highlighted at the top of the page. The jump and highlighting is disconcerting/unexpected. @craxal @v-xianya

[cliffeby]

IMG_3752.zip

This is a video showing both issues.

[craxal]

@cliffeby The jump to the top of the page is by design. All of our editors do that.

As far as the double-selection is concerned, I finally got it to repro. I think I know what's happening. The Delete command, of course, opens a confirmation dialog before proceeding. There's often a (very) short delay between when the command is triggered and the dialog opens. During that delay, the editor can still respond to UI events. In this case, a few things are happening:

• The table loses focus. This results in the selected row changing from dark blue to light blue.
• The UI handles a mouseover at the current location of the cursor. This results in the row under the cursor also being colored light blue.
• The editor UI is blocked as soon as the dialog opens, so the editor doesn't change any hover states.

It just so happens the colors we use for row hover color and row unfocused/selected states are the same color, which is probably where the confusion is coming from. In reality, only one item is selected. If you cancel the confirmation dialog, you should notice the UI update the row hover.

Two possible solutions:

• We have a different style for row hover and row unfocused/selected states.
• Indicate the number of entities that will be deleted in the confirmation dialog.

@jinglouMSFT @MRayermannMSFT @JasonYang-MSFT Thoughts?

[cliffeby]

@craxal @jinglouMSFT @MRayermannMSFT @JasonYang-MSFT

Regarding options, I'd prefer style/color difference as long as it's obvious which is going to be deleted.. For the second possible solution, if the confirmation dialog notes one row to be deleted and two are highlighted, which one is it?

Regarding standard editor behavior, I'm not sure why a jump to the top of the page is desired. Why would I want to go to the top of a page? Could you imagine that behavior in VSCode, Excel or Word?

[craxal]

@cliffeby We try to emulate behaviors observed in File Explorer on Windows or Finder on Mac. Both File Explorer and Finder move the selection to the next item when deleting, so that's something we can look into. If could please open a separate bug for that, we'd greatly appreciate it!