Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off by one error in GetPrefixLocation recursion #584

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix off by one error in GetPrefixLocation recursion #584

merged 2 commits into from
Apr 30, 2024

Conversation

gfs
Copy link
Contributor

@gfs gfs commented Apr 29, 2024

No description provided.

danfiedler-msft
danfiedler-msft approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@danfiedler-msft danfiedler-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this also seems like a good opportunity to add a test for this condition.

@gfs
Copy link
Contributor Author

gfs commented Apr 29, 2024

Will add a test case before merging.

@gfs gfs merged commit e2e13ee into main Apr 30, 2024
11 checks passed
@gfs gfs deleted the gfs/#583 branch April 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfiedler-msft danfiedler-msft danfiedler-msft approved these changes

@scovetta scovetta scovetta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfs @scovetta @danfiedler-msft