fix node8 warnings

microsoft · Apr 23, 2019 · 9655174 · 9655174
1 parent 4319952
commit 9655174
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "applicationinsights-native-metrics",
   "description": "Native APM agent for the Application Insights Node.js SDK",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "contributors": [
     {
       "name": "Application Insights Developer Support",

diff --git a/src/LoopProfiler.cc b/src/LoopProfiler.cc
@@ -5,7 +5,7 @@
 
 namespace ai {
 
-const uint64_t SEC_TO_MICRO = 1e6;
+const uint64_t SEC_TO_MICRO = 1000000;
 
 /**
  * Get loop usage time in us

diff --git a/src/Metric.hh b/src/Metric.hh
@@ -30,15 +30,15 @@ class Metric {
     auto resJson = Nan::New<v8::Object>();
 
     Nan::Set(resJson, Nan::New("total").ToLocalChecked(),
-             Nan::New<v8::Number>(total()));
+             Nan::New<v8::Number>((double)total()));
     Nan::Set(resJson, Nan::New("min").ToLocalChecked(),
-             Nan::New<v8::Number>(min()));
+             Nan::New<v8::Number>((double)min()));
     Nan::Set(resJson, Nan::New("max").ToLocalChecked(),
-             Nan::New<v8::Number>(max()));
+             Nan::New<v8::Number>((double)max()));
     Nan::Set(resJson, Nan::New("count").ToLocalChecked(),
-             Nan::New<v8::Number>(count()));
+             Nan::New<v8::Number>((double)count()));
     Nan::Set(resJson, Nan::New("sumSquares").ToLocalChecked(),
-             Nan::New<v8::Number>(sumSquares()));
+             Nan::New<v8::Number>((double)sumSquares()));
 
     return resJson;
   }