Sergkanz/level up versions #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2016 08:48
dnduffy
suggested changes
Sep 28, 2016
| @@ -38,7 +38,7 @@ | |||
| </None> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <ProjectReference Include="..\..\..\Core\Managed\Net45\Core.Net45.csproj"> | |||
| <ProjectReference Include="..\..\..\Core\Managed\Net40\Core.Net40.csproj"> | |||
There was a problem hiding this comment.
Why are these changing from Net45 to Net40 when the target framework version is still 4.5?
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
There was a problem hiding this comment.
That is explained by Sergey in description: Description: I use the same version of Microsoft.ApplicationInsights.dll in both nuspec. this solves the problem of uneven versions for nugget packages
In reply to: 80967630 [](ancestors = 80967630)
There was a problem hiding this comment.
This reference is for build ordering only. Let me remove it
abaranch
approved these changes
Sep 28, 2016
dnduffy
approved these changes
Sep 28, 2016
TimothyMothra
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Add AspNetCore environment initializer, AuthScript support, Prevent debug logging if instrumentation key exists, Disable debug logger if other loggers are being added to ILoggerFactory * Fix nullref while retrieving ApplicationVersion * Rev package version * Do not use extension method to add debug logger * Fix spelling * Fix param comments * Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the same version of
Microsoft.ApplicationInsights.dllin both nuspec. this solves the problem of uneven versions for nugget packages