Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AspNetCore net461 (prep FrameworkReference) #2415

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Sep 16, 2021

Fix Issue #2251.

We're aligning the AspNetCore project with NetCoreApp3.1, Net5.0, and Net6.0.
Formerly, NetCoreApp2.1 was compatible with targeting Net Framework. This is no longer available in the newer framework versions and we're removing it from this project.

Changes

  • Removing Net461 from AspNetCore project.
  • Removing preprocesosrs.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To make sure we are not missing anything need another look from @rajkumar-rangaraj @vishweshbankwar @reyang

@TimothyMothra TimothyMothra merged commit e2731fe into develop Sep 16, 2021
@TimothyMothra TimothyMothra deleted the tilee/remove_aspnetcore_net461 branch September 16, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants