remove netcoreapp2.1 from projects. clean up csproj #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
changed the title
TimothyMothra
changed the title
cijothomas
reviewed
Aug 2, 2021
| <TargetFrameworks>net452;net46;net461;netcoreapp2.1;netcoreapp3.1;net5.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="$(OS) != 'Windows_NT'">netcoreapp2.1;netcoreapp3.1</TargetFrameworks> | ||
| <TargetFrameworks>net452;net46;net461;netcoreapp3.1;net5.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="$(OS) != 'Windows_NT'">netcoreapp3.1</TargetFrameworks> |
There was a problem hiding this comment.
we can add net5.0 in non-windows
There was a problem hiding this comment.
i want to address net5.0 as a separate PR.
cijothomas
reviewed
Aug 2, 2021
| </Project> |
There was a problem hiding this comment.
Github complains if a file is missing a new-line at the very end. That's the red circle on line 38.
cijothomas
reviewed
Aug 2, 2021
| @@ -28,6 +28,10 @@ | |||
| <Reference Include="System.Net.Http" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | |||
There was a problem hiding this comment.
correct. no change here. i moved the PackageReference to the top half of the file and added a new-line at the very end
cijothomas
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #2251 .
Changes
netcoreapp2.1from projectsChecklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build