Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some new tests for endpoints #1640

Merged
merged 8 commits into from
Jan 27, 2020
Merged

adding some new tests for endpoints #1640

merged 8 commits into from
Jan 27, 2020

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Jan 21, 2020

Fix Issue #1648
Originally reported #1637

Changes

  • Fix for ServerTelemetryChannel to not overwrite endpoint coming from config in Initialize method.
  • Fix for QuickPulseTelemetryModule to set endpoint on QuickPulseTelemetryProcessor during RegisterTelemetryProcessor method.
  • Add new tests for the above scenarios.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra
Copy link
Member Author

Note to self: removing the line in Initialize causes all of the "VerifyEndpointConnectionString_SetFromInitialize" tests to fail.

@TimothyMothra
Copy link
Member Author

Note to self: investigate setting endpoints on TelemetryModules.

TODO Confirm:

  • manual set, before Factory
  • manual set, after Factory

@TimothyMothra TimothyMothra changed the title [WIP] adding some new tests for endpoints adding some new tests for endpoints Jan 27, 2020
@TimothyMothra TimothyMothra marked this pull request as ready for review January 27, 2020 22:51
@TimothyMothra TimothyMothra merged commit 8d2c830 into develop Jan 27, 2020
TimothyMothra added a commit that referenced this pull request Jan 27, 2020
* adding some new tests for endpoints

* fix bug. add new tests

* added tests to quickpulse telemetrymodule

* comments

* remove test

* fix for coded QuickPulse config

* fix typo
@TimothyMothra TimothyMothra deleted the tilee/endpoints branch June 3, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants