Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilee/fix argoutofrange #1529

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Tilee/fix argoutofrange #1529

merged 3 commits into from
Jan 7, 2020

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Jan 6, 2020

Fix Issue #1513

Fixing ArgumentOutOfRangeException.
W3CUtilities could have thrown if IndexOf returns a -1.

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue.

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra TimothyMothra added this to the 2.13 milestone Jan 6, 2020
@TimothyMothra TimothyMothra requested a review from lmolkova January 6, 2020 22:35
@TimothyMothra TimothyMothra merged commit dd90b1e into develop Jan 7, 2020
@TimothyMothra TimothyMothra deleted the tilee/fix_argoutofrange branch January 7, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants