Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix XML Documentation (Rewrite AddXmlLanguage and add to Nupkg Audit) #1495

Merged
merged 7 commits into from
Dec 18, 2019
Merged

fix XML Documentation (Rewrite AddXmlLanguage and add to Nupkg Audit) #1495

merged 7 commits into from
Dec 18, 2019

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Dec 10, 2019 •
edited
Loading

#1214
#1349

adding check to verify that docs includes xml lang

CHANGES

  • Consolidate all AddXmlLanguage.targets files.
  • All project now reference a common target
  • Rewrite AddXmlLanguage.targets
  • Remove manual specification of XML DocumentationFile
  • Remove manual adding doc file to nupkg
  • Use instead GenerateDocumentationFile

@TimothyMothra TimothyMothra added this to the 2.13 milestone Dec 18, 2019
@TimothyMothra TimothyMothra changed the title adding another check to Nupkg Audit fix XML Documentation (Rewrite AddXmlLanguage and add to Nupkg Audit) Dec 18, 2019
@TimothyMothra TimothyMothra merged commit 77c4bca into develop Dec 18, 2019
@TimothyMothra TimothyMothra deleted the tilee/audit branch December 18, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmitry-Matveev Dmitry-Matveev Dmitry-Matveev approved these changes

Assignees
No one assigned
Labels
FUNdamentals sdl
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyMothra @Dmitry-Matveev