Initialize modules only from Active configuration #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abaranch
commented
Nov 10, 2015
abaranch
commented
- Initialize modules collection only when active configuration is accessed and do not initialize it for CreateDefault (Otherwise if application uses both autocollection with ai.config and code instrumentation, telemetry modules are initialized with first configuration accessed that may lead to sending telemetry to the wrong iKey)
- Remove dependency on modules singleton from configuration factory
- Add unit tests for telemetry modules
| using Microsoft.ApplicationInsights.Channel; | ||
| using Microsoft.ApplicationInsights.Extensibility; | ||
| using Microsoft.ApplicationInsights.Extensibility.Implementation.Platform; | ||
|
|
||
| internal class TelemetryConfigurationFactory | ||
| { | ||
| protected string configurationFileContent; |
There was a problem hiding this comment.
let's not keep file content in memory for the entire life of the program.
|
|
abaranch
added a commit
that referenced
this pull request
Nov 10, 2015
Initialize modules only from Active configuration
TimothyMothra
pushed a commit
that referenced
this pull request
Oct 25, 2019
Release 2.3 version for diagnostic source listener only
TimothyMothra
pushed a commit
that referenced
this pull request
Oct 25, 2019
revert EF package names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.