Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Read version information from project.json #29

Closed
rinatkar opened this issue Apr 16, 2015 · 7 comments
Closed

Read version information from project.json #29

rinatkar opened this issue Apr 16, 2015 · 7 comments

Comments

@rinatkar
Copy link

Implement telemetry initializer that populates telemetry.Component.Version to the value read from project.json.
This was blocked before by the issue in Configuration package. More details: aspnet/Configuration#115

@SergeyKanzhelev SergeyKanzhelev modified the milestone: 82.3 Apr 28, 2015
@abaranch abaranch modified the milestones: 84.1, 82.3 May 10, 2015
@SergeyKanzhelev SergeyKanzhelev changed the title Can't read version information from project.json Read version information from project.json Sep 1, 2015
@gzepeda
Copy link
Contributor

gzepeda commented Mar 17, 2016

One question, should the project.json file be loaded as a Configuration File on ASP.NET Core 1 using a ConfigurationBuilder or should it be loaded in a different way?

Trying to figure out the best way to load the file and get the config information from it.

@SergeyKanzhelev
Copy link
Contributor

Are there any other options how to load it? Will ConfigurationBuilder require a new dependency for the package?

@SergeyKanzhelev
Copy link
Contributor

I don't see problems with ConfigurationBuilder

@gzepeda
Copy link
Contributor

gzepeda commented Mar 18, 2016

I will try ConfigurationBuilder then. Just need to add an additional nuget to the project: Microsoft.Extensions.Configuration.Json.

Does the appsettings.json contain version info?

@kartang
Copy link
Contributor

kartang commented Mar 18, 2016

I am sorry for the confusion. I got the question wrong. No, appsettings will not contain the version info.

gzepeda added a commit to gzepeda/ApplicationInsights-aspnetcore that referenced this issue Mar 21, 2016
dnduffy added a commit that referenced this issue Mar 25, 2016
Commit for #29 - Read version information from project.json
@kartang kartang closed this as completed Apr 1, 2016
@xperiandri
Copy link

Does this work without any configuration? Or I need to set up this to work?

@SergeyKanzhelev
Copy link
Contributor

It should work out of the box. Do you see otherwise?

Here are the pointers in code if it would help: reading and setting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants