Use upstream micrometer instrumentation #3245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trask is this ready for review? |
heyams
reviewed
Sep 11, 2023
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
...metry/javaagent/instrumentation/azurefunctions/FunctionEnvironmentReloadInstrumentation.java
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
use-upstream-micrometer-instrumentation
branch
from
dccb415 to
516348f
Compare
trask
force-pushed
the
use-upstream-micrometer-instrumentation
branch
from
516348f to
963ae41
Compare
heyams
reviewed
Sep 19, 2023
...ain/java/com/microsoft/applicationinsights/agent/internal/exporter/BackCompatMetricData.java
Show resolved
Hide resolved
heyams
reviewed
Sep 19, 2023
…er-instrumentation
|
This comment is only for Micrometer < 1.5? |
heyams
approved these changes
Sep 20, 2023
I reworded it a bit, also check out https://github.com/microsoft/ApplicationInsights-Java/pull/3245/files#diff-1b736bfc6f05aef23179b4913d150fb5dad450dbf3297fe3a875dccfed3736b4R191-R199 |
…er-instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO need to manually test old actuator instrumentation, because I haven't been able to get old spring boot versions to work since upgrading to Gradle 8.1.1.
Resolves #2806 and https://portal.microsofticm.com/imp/v3/incidents/incident/409304026
The 63 character limit for OTel metric names which could introduce regressions for existing users by moving to the upstream instrumentation is resolved now in OTel Java v1.30.0.