Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught ReferenceError: global is not defined #1911

Closed
pelikhan opened this issue Oct 3, 2022 · 4 comments
Closed

Uncaught ReferenceError: global is not defined #1911

pelikhan opened this issue Oct 3, 2022 · 4 comments
Assignees
@MSNev
Labels
bug released - NPM
Milestone
shims-2.0.2

Comments

@pelikhan
Copy link
Member

pelikhan commented Oct 3, 2022

This call blows up when trying to build AI with gatsbyjs. Is this function missing "else" statement? It seems from the description that the globalThis should be but in practice each clause gets entered until the global check fails.

ApplicationInsights-JS/tools/shims/src/Helpers.ts

Line 38 in 06c1469

if (typeof global !== strShimUndefined && global) {

@MSNev MSNev self-assigned this Oct 3, 2022
@MSNev MSNev added the bug label Oct 3, 2022
@MSNev
Copy link
Collaborator

MSNev commented Oct 3, 2022 •
edited
Loading

Yeh, this shouldn't keep "replacing" the _cachedGlobal once it's found the "global".

I'm a little surprised that this hasn't been raised as an issue already...

MSNev added a commit that referenced this issue Oct 3, 2022
@MSNev
Uncaught ReferenceError: global is not defined #1911
f6951f7
@MSNev MSNev added this to the 2.8.9 milestone Oct 3, 2022
@MSNev
Copy link
Collaborator

MSNev commented Oct 3, 2022

This issue has "just" missed the release of 2.8.8, so it's currently scheduled for v2.8.9 (which will normally rollout at the end of oct (early November)) and that will be the last scheduled release of 2022.

MSNev added a commit that referenced this issue Oct 3, 2022
@MSNev
Uncaught ReferenceError: global is not defined #1911
308c4dc
MSNev added a commit that referenced this issue Oct 11, 2022
@MSNev
Uncaught ReferenceError: global is not defined #1911 (#1913)
ff74ca8
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Oct 11, 2022
MSNev added a commit that referenced this issue Oct 12, 2022
@MSNev
Uncaught ReferenceError: global is not defined #1911
ba9d0dd
@MSNev MSNev modified the milestones: 2.8.9, shims-2.0.2 Oct 24, 2022
@MSNev
Copy link
Collaborator

MSNev commented Oct 24, 2022

Shims v2.0.2 is now published with this fix.
v2.8.9 of AI will be updated to consume

@MSNev MSNev closed this as completed Oct 31, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug released - NPM
Projects
None yet
Milestone
shims-2.0.2
Development

No branches or pull requests
2 participants
@pelikhan @MSNev