Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when calling simLoadLevel #3341

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

niekvleeuwen
Copy link
Contributor

Fixes #3340

About

Fixed Unreal Engine crash when calling simLoadLevel.

How Has This Been Tested?

I tested this fix on ubuntu 18.04 with UE4 4.25

@rajat2004
Copy link
Contributor

rajat2004 commented Jan 31, 2021

Hmm, wasn't aware that simLoadLevel is usable, hasn't been added to client.py as well till now
Doesn't it require some levels or modifications to the envs?

@niekvleeuwen
Copy link
Contributor Author

Yes it is actually usable! I am indeed using a custom environment with multiple maps and the C++ API. I tested this function because I noticed it in the code and, apart from the above fix, the feature works quite well. As stated in #2651, the function is not added to Python client because it could confuse users.

zimmy87 added 2 commits June 1, 2021 11:15
applying clang-format style changes
exposing simLoadLevel API to python client
@zimmy87 zimmy87 merged commit 31f38b6 into microsoft:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when calling simLoadLevel
4 participants