Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS] Add grid ImageSet style #8845

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

paulcam206
Copy link
Member

Adding a new ImageSet style to allow for a cleaner presentation. Also improve default ImageSet rendering.

Old ImageSet render (default style)

image

New ImageSet render (default style)

image
(a small tweak -- just added vertical padding)

New ImageSet grid style

Schema

{
  "type": "ImageSet",
  "style": "grid",
  "images": [ ]
}

Screenshots

Small

image

Medium

image

Large

image

Large (rtl)

image

@jwoo-msft
Copy link
Member

jwoo-msft commented Mar 5, 2024

@paulcam206, Do you think we need to create a tag for new features to be attached to the commit, so that we can easily pull those features when we want to bring each platform to parity?

@paulcam206
Copy link
Member Author

@paulcam206, Do you think we need to create a tag for new features to be attached to the commit, so that we can easily pull those features when we want to bring each platform to parity?

good idea, I created the NodeJS-2403 label to track.

@paulcam206 paulcam206 force-pushed the paulcam/add-imageset-class branch from 67f7109 to d9375a3 Compare March 5, 2024 19:20
@paulcam206 paulcam206 force-pushed the paulcam/add-imageset-class branch from d9375a3 to 5aa166e Compare March 7, 2024 21:52
@paulcam206 paulcam206 enabled auto-merge (squash) March 7, 2024 21:52
@paulcam206 paulcam206 merged commit 0152d5c into main Mar 7, 2024
8 checks passed
@paulcam206 paulcam206 deleted the paulcam/add-imageset-class branch March 7, 2024 22:09
jwoo-msft pushed a commit that referenced this pull request May 1, 2024
jwoo-msft added a commit that referenced this pull request May 1, 2024
* Fix `--blue` to be a _smidge_ darker (better contrast on `--black`) (#8745)

* Remove unnecessary `aria-required` property from container element (#8746)

* Add `hljs-comment` color to fix contrast (#8747)

* Switch from textblock to label in Input.Time sample (#8751)

* Add missing img alt text in a few spots (#8750)

* Slight tweak to common blue background/border color for contrast (#8748)

* Add missing `title` to `iframe` in blog post (#8754)

* [Samples] Update version for samples using `tooltip` (#8753)

* [Designer] Fix treeview control accessibility (#8757)

* fixed a11y issue (#8760)

* Update README.md (#8802)

* Added AdaptiveCards Template WinRT Component (#8805)

* added a new project file

* added test app and c# winrt component

* mostly working?

* fix impl

* updated nuget path

* added c# runtime component

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* update

* removed winrt prject from AC and added C++ console sample app and the AC project to visualizer

* removed nuget config changes

---------

Co-authored-by: Paul Campbell <[email protected]>

* Jwoo/template winrt strong name (#8807)

* added a new project file

* added test app and c# winrt component

* mostly working?

* fix impl

* updated nuget path

* added c# runtime component

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* update

* removed winrt prject from AC and added C++ console sample app and the AC project to visualizer

* removed nuget config changes

* added strong name

* added new property

---------

Co-authored-by: Paul Campbell <[email protected]>

* Added Package Info (#8811)

* added missing package info

* for sharing

* updated

* Update README.md (#8813)

* Add headingLevel to host config (#8814)

* Update action icon role to presentation (#8815)

* Update README.md (#8817)

Update release schedule for website

* Fix invalid color value (#8819)

* [NodeJS] Update hashing algorithm for webpack (#8835)

* Update hashing algorithm for webpack

Needed to unblock Node >16

* Tabs -> spaces

* [NodeJS] Add `ImageSet` class to enable styling (#8838)

* [NodeJS] Add optional overflow menu icon rendering (#8847)

* Remove tab index from nested inputs (#8848)

* [NodeJS] Add `grid` `ImageSet` style (#8845)

* Host old content from messagecardplayground on ac.io (#8866)

* Fix issue #8520 (#8870)

Updated AdaptiveTableCell to override the Type property

Co-authored-by: huberemanuel <[email protected]>

* Update README.md (#8873)

Update icon for unsupported features

* Update README.md (#8859)

* Add tooltip for Arabic (#8890)

* [Website][A11y] Update keyboard nav for blog posts (#8891)

* Update keyboard nav for blog posts

* Add up/down navigation

* Navigate on enter

* Designer surface a11y updates (#8888)

* Designer surface a11y updates

* Update source/nodejs/adaptivecards-designer/src/peer-command.ts

Co-authored-by: Paul Campbell <[email protected]>

---------

Co-authored-by: Paul Campbell <[email protected]>

---------

Co-authored-by: Paul Campbell <[email protected]>
Co-authored-by: anna-dingler <[email protected]>
Co-authored-by: Matej Simek <[email protected]>
Co-authored-by: huberemanuel <[email protected]>
jwoo-msft added a commit that referenced this pull request May 1, 2024
* Fix `--blue` to be a _smidge_ darker (better contrast on `--black`) (#8745)

* Remove unnecessary `aria-required` property from container element (#8746)

* Add `hljs-comment` color to fix contrast (#8747)

* Switch from textblock to label in Input.Time sample (#8751)

* Add missing img alt text in a few spots (#8750)

* Slight tweak to common blue background/border color for contrast (#8748)

* Add missing `title` to `iframe` in blog post (#8754)

* [Samples] Update version for samples using `tooltip` (#8753)

* [Designer] Fix treeview control accessibility (#8757)

* fixed a11y issue (#8760)

* Update README.md (#8802)

* Added AdaptiveCards Template WinRT Component (#8805)

* added a new project file

* added test app and c# winrt component

* mostly working?

* fix impl

* updated nuget path

* added c# runtime component

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* update

* removed winrt prject from AC and added C++ console sample app and the AC project to visualizer

* removed nuget config changes

---------

Co-authored-by: Paul Campbell <[email protected]>

* Jwoo/template winrt strong name (#8807)

* added a new project file

* added test app and c# winrt component

* mostly working?

* fix impl

* updated nuget path

* added c# runtime component

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* updated

* update

* removed winrt prject from AC and added C++ console sample app and the AC project to visualizer

* removed nuget config changes

* added strong name

* added new property

---------

Co-authored-by: Paul Campbell <[email protected]>

* Added Package Info (#8811)

* added missing package info

* for sharing

* updated

* Update README.md (#8813)

* Add headingLevel to host config (#8814)

* Update action icon role to presentation (#8815)

* Update README.md (#8817)

Update release schedule for website

* Fix invalid color value (#8819)

* [NodeJS] Update hashing algorithm for webpack (#8835)

* Update hashing algorithm for webpack

Needed to unblock Node >16

* Tabs -> spaces

* [NodeJS] Add `ImageSet` class to enable styling (#8838)

* [NodeJS] Add optional overflow menu icon rendering (#8847)

* Remove tab index from nested inputs (#8848)

* [NodeJS] Add `grid` `ImageSet` style (#8845)

* Host old content from messagecardplayground on ac.io (#8866)

* Fix issue #8520 (#8870)

Updated AdaptiveTableCell to override the Type property

Co-authored-by: huberemanuel <[email protected]>

* Update README.md (#8873)

Update icon for unsupported features

* Update README.md (#8859)

* Add tooltip for Arabic (#8890)

* [Website][A11y] Update keyboard nav for blog posts (#8891)

* Update keyboard nav for blog posts

* Add up/down navigation

* Navigate on enter

* Designer surface a11y updates (#8888)

* Designer surface a11y updates

* Update source/nodejs/adaptivecards-designer/src/peer-command.ts

Co-authored-by: Paul Campbell <[email protected]>

---------

Co-authored-by: Paul Campbell <[email protected]>

* updated version

---------

Co-authored-by: Paul Campbell <[email protected]>
Co-authored-by: anna-dingler <[email protected]>
Co-authored-by: Matej Simek <[email protected]>
Co-authored-by: huberemanuel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants