Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carousel A11y]: Change focus order to first focus carousel pages and navigation controls second #8709

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

beervoley
Copy link
Contributor

Related Issue

Closing https://microsoft.visualstudio.com/OS/_workitems/edit/40328002.

Description

The bug above states that the focus order when navigating Carousel via keyboard is incorrect.
Current order: Any Outer Element -> Left Navigation Button (if enabled) -> Navigation Bullets -> Right Navigation Button (if enabled) -> Carousel Page.
Expected order: Any Outer Element -> Carousel Page -> Left Navigation Button (if enabled) -> Navigation Bullets -> Right Navigation Button (if enabled).

Since tabIndex = 0 on elements of CarouselPage and Navigation Controls tab order will match the order of the elements in DOM. Currently container for navigation controls is added to the DOM before the container for carousel pages. I've changed the order to insert container for carousel pages first to change the tab order to desired one.

Sample Card

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "Carousel",
            "rtl": false,
            "loop": false,
            "pages": [
                {
                    "type": "CarouselPage",
                    "rtl": false,
                    "items" : [
                        {
                            "type" : "Image",
                            "url" : "https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg"
                        }
                    ]
                },
                {
                    "type": "CarouselPage",
                    "rtl": false,
                    "items" : [
                        {
                            "type" : "Image",
                            "url" : "https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg"
                        }
                    ]
                },
                 {
                    "type": "CarouselPage",
                    "rtl": false,
                    "items" : [
                        {
                            "type" : "Image",
                            "url" : "https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg"
                        }
                    ]
                }
            ]
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.6"
}

How Verified

Manually verified by tabbing through the sample card in designer.

@beervoley beervoley added the A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score label Oct 16, 2023
@jwoo-msft jwoo-msft merged commit a0fe574 into main Oct 26, 2023
@jwoo-msft jwoo-msft deleted the u/vsiliush/a11y-change-tab-order-carousel branch October 26, 2023 09:02
kunalnagar referenced this pull request in kunalnagarco/action-cve Feb 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [adaptivecards](https://adaptivecards.io)
([source](https://togithub.com/microsoft/AdaptiveCards)) | [`2.11.3` ->
`3.0.2`](https://renovatebot.com/diffs/npm/adaptivecards/2.11.3/3.0.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/adaptivecards/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/adaptivecards/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/adaptivecards/2.11.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/adaptivecards/2.11.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>microsoft/AdaptiveCards (adaptivecards)</summary>

###
[`v3.0.2`](https://togithub.com/microsoft/AdaptiveCards/releases/tag/adaptivecards%403.0.2):
23.10 JS Renderer Release

[Compare
Source](https://togithub.com/microsoft/AdaptiveCards/compare/[email protected])

### Latest Packages

🎉[JS adaptivecards
3.0.2](https://www.npmjs.com/package/adaptivecards/v/3.0.2)

#### Fixes

-
[https://github.com/microsoft/AdaptiveCards/issues/8574](https://togithub.com/microsoft/AdaptiveCards/issues/8574)
-
[https://github.com/microsoft/AdaptiveCards/pull/8709](https://togithub.com/microsoft/AdaptiveCards/pull/8709)
-
[https://github.com/microsoft/AdaptiveCards/issues/8654](https://togithub.com/microsoft/AdaptiveCards/issues/8654)

###
[`v3.0.1`](https://togithub.com/microsoft/AdaptiveCards/compare/ac010094d2afd0f11a2a442eccf3bde7ed93f388...56c8e863a093ba24b43a8ff294dcf7153d168dfc)

[Compare
Source](https://togithub.com/microsoft/AdaptiveCards/compare/ac010094d2afd0f11a2a442eccf3bde7ed93f388...56c8e863a093ba24b43a8ff294dcf7153d168dfc)

###
[`v3.0.0`](https://togithub.com/microsoft/AdaptiveCards/compare/fd749b7de6db0dc5a5e120831ef97722c334fae2...ac010094d2afd0f11a2a442eccf3bde7ed93f388)

[Compare
Source](https://togithub.com/microsoft/AdaptiveCards/compare/fd749b7de6db0dc5a5e120831ef97722c334fae2...ac010094d2afd0f11a2a442eccf3bde7ed93f388)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kunalnagarco/action-cve).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants