[UWP] Add role property to actions #8337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwoo-msft @almedina-ms Do we need any changes for Android or iOS here? |
jwoo-msft
approved these changes
Mar 7, 2023
beervoley
reviewed
Mar 7, 2023
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* WIP: adding role to actions - UWP * Remove link button class * switch to actionRole * Fix formatting * Unit test updates * Formatting * Update everything bagel and winui3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Progress towards #8041
Description
Added a new property
roleto actions. The new property will allow the card author to specify an aria role for a buttons and improve their card's accessibility.Proposal can be found here: #8041 (comment)
Sample Card
Added a sample card for v1.6
How Verified
Verified manually in the Visualizer with Narrator.
Microsoft Reviewers: Open in CodeFlow