Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwoo/js keyboard fix #8299

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Jwoo/js keyboard fix #8299

merged 5 commits into from
Feb 10, 2023

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Feb 9, 2023

Related Issue

https://microsoft.visualstudio.com/OS/_sprints/taskboard/OWL%20(Open%20Windows%20Platform).SnaX.Team/OS/2302?workitem=43065527

Description

Navigating through carousel pages using arrow keys will turn the pages of all carousels within a browser.
To fix the issue.

  1. disable navigation via arrow keys
  2. add keyboard event handler to bullets.

Sample Card

N/A

How Verified

Created a test app to test this use case.

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft enabled auto-merge (squash) February 10, 2023 01:30
@jwoo-msft jwoo-msft merged commit a4bdca0 into main Feb 10, 2023
@jwoo-msft jwoo-msft deleted the jwoo/js-keyboard-fix branch February 10, 2023 01:56
jwoo-msft added a commit that referenced this pull request Feb 16, 2023
* this is test changes

* disabled keyboard navigation by arrows key

* revert package changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants