-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UWP Renderer] Update ActionSet fallback #8233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update custom.props for object model release * Updated Xcode version (#8222) * removed build step as they are redundant (#8201) * removed build step as they are redundant * added pod installation step Co-authored-by: Joseph Woo <[email protected]>
* Update custom.props for object model release * Updated Xcode version (#8222) * removed build step as they are redundant (#8201) * removed build step as they are redundant * added pod installation step * Add a null check for inline Actions Co-authored-by: Joseph Woo <[email protected]>
Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
jwoo-msft
approved these changes
Jan 26, 2023
Staleness reset by anna-dingler |
…o anna/updateActionSetFallback
…rosoft/AdaptiveCards into anna/updateActionSetFallback
anna-dingler
commented
Mar 8, 2023
beervoley
reviewed
Mar 20, 2023
beervoley
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #8323
Description
When attempting to handle the fallback scenario for an action, we throw an
E_FAIL
error if no mechanism is provided (default).AdaptiveCards/source/uwp/SharedRenderer/lib/ActionHelpers.cpp
Lines 734 to 756 in 38b8f09
This error is never handled, and an error is shown in the visualizer.
I added a try/catch block surrounding this method call so that we continue rendering even if we drop the action.
I also updated the
actionType
when gettingFallbackContent
.Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Elements/ActionFallback.json
How Verified
Verified manually on the AdaptiveCards Visualizer.
Microsoft Reviewers: Open in CodeFlow