-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing line breaks with <br> in markdown text #7184
Merged
jwoo-msft
merged 7 commits into
microsoft:main
from
janusbal:jbalatbat/supportin_newline_onmarkdown
Apr 14, 2022
Merged
Replacing line breaks with <br> in markdown text #7184
jwoo-msft
merged 7 commits into
microsoft:main
from
janusbal:jbalatbat/supportin_newline_onmarkdown
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
reviewed
Apr 5, 2022
jwoo-msft
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
licanhua
reviewed
Apr 7, 2022
licanhua
approved these changes
Apr 8, 2022
…ub.com/janusbal/AdaptiveCards-1 into jbalatbat/supportin_newline_onmarkdown
jwoo-msft
pushed a commit
that referenced
this pull request
May 11, 2022
* replacing line breaks with <br> * addressing PR comment * clang format Co-authored-by: Janus Balatbat <[email protected]>
paulcam206
pushed a commit
that referenced
this pull request
May 12, 2022
* Replacing line breaks with <br> in markdown text (#7184) * replacing line breaks with <br> * addressing PR comment * clang format Co-authored-by: Janus Balatbat <[email protected]> * fixed vo announcing misspelled words (#7443) Co-authored-by: janusbal <[email protected]> Co-authored-by: Janus Balatbat <[email protected]>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* replacing line breaks with <br> * addressing PR comment * clang format Co-authored-by: Janus Balatbat <[email protected]>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* replacing line breaks with <br> * addressing PR comment * clang format Co-authored-by: Janus Balatbat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android, web and desktop support
\n
in markdown texts while iOS does not. This adds support to line breaks by replacing them withhtml tag before generating the html string.
Sample Card
How Verified
How you verified the fix, including one or all of the following:
will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow