[Android] Support Action.isEnabled #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
reviewed
May 5, 2021
...ndroid/adaptivecards/src/main/java/io/adaptivecards/renderer/readonly/ContainerRenderer.java
Show resolved
Hide resolved
paulcam206
approved these changes
May 5, 2021
Yes! Yet, it thinks this file should have tabs (bottom info bar).
I'd sooner use vim :) |
Actually, Lines 10 to 11 in a05ba75
you can do that in emacs! |
jwoo-msft
approved these changes
May 6, 2021
ghost
added
the
|
Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @golddove; Thanks for taking action on your previously stale pull request. Resetting staleness. |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [Android] Support Action.isEnabled * VSCode will figure out indentation one day... * Missing SWIG file * VSCode was right all along * Outcome of design discussion
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [Android] Support Action.isEnabled * VSCode will figure out indentation one day... * Missing SWIG file * VSCode was right all along * Outcome of design discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5719
Description
selectActionorinlineActionwithisEnabled: falseare not clickable.selectActionwithisEnabled: falseare rendered as if there is noselectActionprovidedActionSet actions withisEnabled: false` are not clickable AND get platform's disabled button appearance.isEnabled(the SDK doesn't impose any enabling/disabling)Sample Card
Updated
v1.5\Elements\Action.isEnabledsample to include RichTextBlockHow Verified
Microsoft Reviewers: Open in CodeFlow