Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP visualizer app improvements #565

Merged
merged 5 commits into from
Sep 11, 2017

Conversation

andrewleader
Copy link
Contributor

Massive improvement to the UWP Visualizer app

  • Tabbed viewing of files! Tabs are on the left though cause it’s cool and different
  • Warnings and errors displayed!
  • Remembers which files you had open after relaunch
  • Instant preview of card, rather than having to click generate
  • Can save changes on a file right from the app

In a future version we need to...

  • Ability to edit host config
  • Ability to save a newly created file
  • Ability to save over the provided sample files (saving into an AppData folder instead)
  • Remember which specific tab was last open and restore that on relaunch
  • Change the color of the window title bar so it matches the top command bar

But I'm going on vacation so want to get these major improvements in now! Screenshots...

image

image

Tabbed UI, error reporting and warnings, instant preview as you type, remembers the files you had open, automatically launches with the samples files open, can save changes on a file
@msftclas
Copy link

@Anbare,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@matthidinger
Copy link
Member

Literally 🔥

Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be missing some files. Does not build. I'll see if I can find the reason. If not we'll have to wait for Andrew to come back.

<Compile Include="Helpers\BindableBase.cs" />
<Compile Include="Helpers\IListExtensions.cs" />
<Compile Include="Helpers\PayloadValidator.cs" />
<Compile Include="Helpers\WeakEventHandler.cs" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[](start = 4, length = 49)

This file is missing

@riarenas
Copy link
Member

Build failed with:
Error : Your project is not referencing the "UAP,Version=v10.0.10586" framework. Add a reference to "UAP,Version=v10.0.10586" in the "frameworks" section of your project.json, and then re-run NuGet restore.

@andrewleader
Copy link
Contributor Author

Looks like it might be an issue with the build server not using NuGet 4.1.0? NuGet/Home#4515

@riarenas
Copy link
Member

@nesalang Please look into this.

Andrew Bares added 3 commits September 11, 2017 10:28
Hopefully this fixes the server's build issue with the app
See if setting min version to 14393 fixes the server build error
@andrewleader andrewleader merged commit a6eb721 into master Sep 11, 2017
@andrewleader andrewleader deleted the anbare/uwp-visualizer-improvements branch September 11, 2017 18:37
@microsoft microsoft deleted a comment Feb 26, 2019
@microsoft microsoft deleted a comment Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants