-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Overflow actions (flyout menu) #4715 (Pre-Release) #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @robin-liao. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
dclaux
approved these changes
Mar 1, 2021
golddove
added a commit
that referenced
this pull request
Apr 14, 2021
* [JS] Overflow actions (flyout menu) #4715 (Pre-Release) (#5446) * [JS] Overflow actions #4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * Js/tooltips headings (#5608) * Schema 1.4 (#5317) * Schema update for Action.Execute and refresh * Generate 1.4 schema file * Updated specs * Update toc.yml * Updated specs * Add authentication * Updated specs * Fix typos * Add missing Action.Execute.verb * Update verbiage * Add Action.Execute sample * Table of contents updates and labels on the sample inputs Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [JS] Add support for Universal Actions (#5533) * Work in progress * strictNullChecks, noImplicitAny noImplicitReturns, noImplicitThis, noUnusedLocals noFallthroughCasesInSwitch More refactoring Work in progress * var --> let * Array<type> --> type[] for (let i = 0 ...) --> for (let item of ...) Additional cleanup Work in progress * null --> undefined where appropriate * Code organizing plus some cleanup * CardObject, CardElement, TextBlock now use schema * Image, FactSet now use schema * FactSet fully uses schema * Library size reduction * Looking at decorators... * Fully move to decorators * Some cleanup * selectAction/inlineAction --> schema * ChoiceSet/ToggleInput --> schema * Media -> schema * All inputs --> schema * Fix IE11 compat (don't use obj.constructor.name) * OpenUrl/ToggleVis./Submit -> schema * Action.Http --> schema * Everything now uses schema * Merge changes from master * Fix designer build break * Add version info in type registries Plus some cleanup * Forgot to add v1.2 to ToggleVisibility * API simplification * Library size reduction (~2 KB minified) * Reduce library size * Small simplification * Update README wih notable changes so far * More simplifications * More simplification + 1KB size reduction * More simplification + bug fix * Parse logic refactor (WIP) * Refactor parse logic (WIP) * Move designer off global registry * Small cLeanup * Refactor toJSON * Parse/serialize to/from specific schema version Full version picker support Still WIP, but almost there * Code complete - full version picker support * Fix test case + minor tweak * Designer bug fixes and minor enhancements * Review feedback so far + designer improvements * Designer bug fixes * Add support for cancelling d&d with ESC * Review feedback + fix value type for number input * Address review feedback * More review feedback * Fix Image.Width/Height serialization regression * Fix Action.Submit not incl. empty inputs anymore Add onExecuteAction handler in Preview Mode * Small designer tweak * Small popup control refactor * [Designer] Enhanced data binding support * [Designer] Small tweak/fix * [Designer] Improved sample data support * Use correct sample data in Preview Mode * Integrate changes from master * Add support for "preview" param on designer URL Hide data structure toolbox * [Designer] Enhanced sample picker dialog * Fix integration mistake * [Designer] Combine open sample and new card buttons Also fully remove "full screen" button * Remove references to removed buttons * Sample picker tweaks * Fix nasty regression introduced by fix in master * [Designer] Add CHANGELOG.md * Publishing preview designer + AC JS packages * [Designer] HostContainer controls target version * [Designer] Adding getCard and setCard back * bump package versions for beta release * Update README.md * Improve experience for modern browsers * [Designer] Add modulus, round, ceil, floor func. [Renderer] Serialization bug fixes * Update README * Small cleanup * Work in progress * Work in progress * [Templating] Fix $when not working within loops [Renderer] Dynamically convert values to string for string properties * [Templating] Add toString, parseInt, parseFloat Refactor function storage to avoid name conflicts [Renderer] Revert automatic conversion to string * CLeanup * Work in progress * Work in progress * Work in progress * Small fixes * [Designer] Styling update * [Designer] Styling update * Work in progress * Work in progress * Work in progress * Disable lockDataStructure * Work in progress * Work in progress * Package-lock updates * Work in progress * Move to Adaptive Expression * Cleanup * Templating tweaks + initial doc generation * [Templating] Bug fixes * Add null check for this.renderedElement * updated website pacakge versions. removed const from exported enums * [Templating] Fix regr introduced with last commit Update README.ms * [Templating] Fix broken {{Date}} and {{TIME}} * fix website templating script based on API changes * Changes to accommodate Schema changes (#3967) * Changes to accommodate Schema changes: * appId property - removed * autoRefresh property - renamed * userIds and displayCardWhenRefresh properties inside refresh - removed * Renamed ActivityInvocationContext.Refresh to ActivityInvocationContext.Automatic * Renamed ActivityInvocationContext as ActivityInvocationTrigger * Moving ActivityInvocationTrigger inside InvokeActivity as per design * Update to use AEL * Better auto refresh handling * update template samples location and where website loads them from * Updated the Scenarios * Fix website - load Monaco before designer init * Update designer README * ported samples updates from .net branch * [Site] Fix data sample not loading * variable misnamed * Add built-in refresh button * Fix data structure gen from null * update site script * Fix duplicated refresh button * Small doc fix * Update to AEL 4.9.0-rc4 * Revert "Update to AEL 4.9.0-rc4" This reverts commit e3a0d77. * Upgrade to AEL 4.9.0-rc5 * Updated samples and added Elements cards * Revert "Merge branch 'ts/renderer-refactor' of github.com:Microsoft/AdaptiveCards into ts/renderer-refactor" This reverts commit 858c7c0, reversing changes made to 7cd9ef6. * Revert "Updated samples and added Elements cards" This reverts commit 7cd9ef6. * Updated Samples * Revert "Updated Samples" This reverts commit 94d5e35. * one git automatic merge led to build errors and had to revert several commits * updated samples and added Elements payload after fixing bungled merge * [Designer] Bump Teams to 1.2 * site new card dialog loads template versions now * update stock template * Update dependencies * Npm audit fix * Incorporate changes from main * Merge AAF code into renderer package * removing failing test for now to test AAF publishing * update AC package version to 3.x for AAF testing * Make AdaptiveApplet registries public * Fix new syntax error * New AdaptiveApplet.onExecuteAction event * Add AdaptiveApplet.hostConfig * Allow blocking manual refreshes * Add support for per-action progress indicator * Refactor to make UB model part of main SDK Add support for providing custom SerializationContext to AdaptiveApplet * Some refactoring to support auth model * Package cleanup * More refactoring for auth support * Web Chat support schema 1.3 (#5514) Co-authored-by: Paul Campbell <[email protected]> * Some renaming * Fix weird discrepancy with main * Auth support complete * Add anchor right click support Cleanup * Tweaks Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> * Update Action.Execute.json Update doc URL for Action.Execute * [Shared] 1.4 - Action.Execute (#5539) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * Fix ShouldSerialize Co-authored-by: Rebecca Muraira <[email protected]> * [.NET] Add support for parsing schema 1.4 features (#5531) * [.NET] Add support for parsing schema 1.4 features * PR feedback * PR feedback * [Android] Action.Execute support (#5551) * Fix SWIG ordering * Action.Execute support * Revert ParseUtil::GetValueAsString; not a duplicate * Bump version * [iOS] Action.Execute Changes (#5549) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * [iOS] Action.Execute ios change * [iOS] exposed auth card to the root card * [iOS] fixed typo * added unit tests * [iOS] Added Action.Execute Renderer * [iOS] CR Comments Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [UWP] Add parsing of schema 1.4 changes and Action.Excute support (#5554) * [UWP] Add parsing of schema 1.4 changes and Action.Excute support * Fix SAL Co-authored-by: Joseph Woo <[email protected]> * Add validation + Action.Execute test card * [iOS] updated text view to update its intrinsic content size dynamically (#5560) * [JS] Universal Action designer support + some bug fixes (#5565) * Universal Actions designer support Plus some bug fixes * Cleanup * [JS] Action.description and TextBlock.style * version update for Android * description --> tooltip * Bump custom.props version * [JS] Updated package deps * [JS] Updated package versions * Metrics for layout structure comparison (#5576) * Added bleu score metric collection for layout structure comparions * latest changes based on review comments * removed OrderedDict for sorting * latest changes * command usage changes * [shared] Parser support for TextBlock headings changes (#5577) * [Shared] Text Heading Support * Added Samples * changed spaces to tabs in .json * [iOS] Text heading changes (#5584) * [Shared] Text Heading Support * Added Samples * [iOS] Text heading changes * [Android][Accessibility] TextBlock style: heading (#5587) * [Android] Accessible Headings * Bump to 1.5 * Missed SWIG enum * [UWP][Shared] Implement Text Heading Object model for UWP and fix shared model serialization (#5601) * Remove tooltip implementation * Remove tooltip from schema * Remove tooltip (description) from designer Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Keerthana Manoharan <[email protected]> * [JS] TextBlock.style (#5607) * Schema 1.4 (#5317) * Schema update for Action.Execute and refresh * Generate 1.4 schema file * Updated specs * Update toc.yml * Updated specs * Add authentication * Updated specs * Fix typos * Add missing Action.Execute.verb * Update verbiage * Add Action.Execute sample * Table of contents updates and labels on the sample inputs Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [JS] Add support for Universal Actions (#5533) * Work in progress * strictNullChecks, noImplicitAny noImplicitReturns, noImplicitThis, noUnusedLocals noFallthroughCasesInSwitch More refactoring Work in progress * var --> let * Array<type> --> type[] for (let i = 0 ...) --> for (let item of ...) Additional cleanup Work in progress * null --> undefined where appropriate * Code organizing plus some cleanup * CardObject, CardElement, TextBlock now use schema * Image, FactSet now use schema * FactSet fully uses schema * Library size reduction * Looking at decorators... * Fully move to decorators * Some cleanup * selectAction/inlineAction --> schema * ChoiceSet/ToggleInput --> schema * Media -> schema * All inputs --> schema * Fix IE11 compat (don't use obj.constructor.name) * OpenUrl/ToggleVis./Submit -> schema * Action.Http --> schema * Everything now uses schema * Merge changes from master * Fix designer build break * Add version info in type registries Plus some cleanup * Forgot to add v1.2 to ToggleVisibility * API simplification * Library size reduction (~2 KB minified) * Reduce library size * Small simplification * Update README wih notable changes so far * More simplifications * More simplification + 1KB size reduction * More simplification + bug fix * Parse logic refactor (WIP) * Refactor parse logic (WIP) * Move designer off global registry * Small cLeanup * Refactor toJSON * Parse/serialize to/from specific schema version Full version picker support Still WIP, but almost there * Code complete - full version picker support * Fix test case + minor tweak * Designer bug fixes and minor enhancements * Review feedback so far + designer improvements * Designer bug fixes * Add support for cancelling d&d with ESC * Review feedback + fix value type for number input * Address review feedback * More review feedback * Fix Image.Width/Height serialization regression * Fix Action.Submit not incl. empty inputs anymore Add onExecuteAction handler in Preview Mode * Small designer tweak * Small popup control refactor * [Designer] Enhanced data binding support * [Designer] Small tweak/fix * [Designer] Improved sample data support * Use correct sample data in Preview Mode * Integrate changes from master * Add support for "preview" param on designer URL Hide data structure toolbox * [Designer] Enhanced sample picker dialog * Fix integration mistake * [Designer] Combine open sample and new card buttons Also fully remove "full screen" button * Remove references to removed buttons * Sample picker tweaks * Fix nasty regression introduced by fix in master * [Designer] Add CHANGELOG.md * Publishing preview designer + AC JS packages * [Designer] HostContainer controls target version * [Designer] Adding getCard and setCard back * bump package versions for beta release * Update README.md * Improve experience for modern browsers * [Designer] Add modulus, round, ceil, floor func. [Renderer] Serialization bug fixes * Update README * Small cleanup * Work in progress * Work in progress * [Templating] Fix $when not working within loops [Renderer] Dynamically convert values to string for string properties * [Templating] Add toString, parseInt, parseFloat Refactor function storage to avoid name conflicts [Renderer] Revert automatic conversion to string * CLeanup * Work in progress * Work in progress * Work in progress * Small fixes * [Designer] Styling update * [Designer] Styling update * Work in progress * Work in progress * Work in progress * Disable lockDataStructure * Work in progress * Work in progress * Package-lock updates * Work in progress * Move to Adaptive Expression * Cleanup * Templating tweaks + initial doc generation * [Templating] Bug fixes * Add null check for this.renderedElement * updated website pacakge versions. removed const from exported enums * [Templating] Fix regr introduced with last commit Update README.ms * [Templating] Fix broken {{Date}} and {{TIME}} * fix website templating script based on API changes * Changes to accommodate Schema changes (#3967) * Changes to accommodate Schema changes: * appId property - removed * autoRefresh property - renamed * userIds and displayCardWhenRefresh properties inside refresh - removed * Renamed ActivityInvocationContext.Refresh to ActivityInvocationContext.Automatic * Renamed ActivityInvocationContext as ActivityInvocationTrigger * Moving ActivityInvocationTrigger inside InvokeActivity as per design * Update to use AEL * Better auto refresh handling * update template samples location and where website loads them from * Updated the Scenarios * Fix website - load Monaco before designer init * Update designer README * ported samples updates from .net branch * [Site] Fix data sample not loading * variable misnamed * Add built-in refresh button * Fix data structure gen from null * update site script * Fix duplicated refresh button * Small doc fix * Update to AEL 4.9.0-rc4 * Revert "Update to AEL 4.9.0-rc4" This reverts commit e3a0d77. * Upgrade to AEL 4.9.0-rc5 * Updated samples and added Elements cards * Revert "Merge branch 'ts/renderer-refactor' of github.com:Microsoft/AdaptiveCards into ts/renderer-refactor" This reverts commit 858c7c0, reversing changes made to 7cd9ef6. * Revert "Updated samples and added Elements cards" This reverts commit 7cd9ef6. * Updated Samples * Revert "Updated Samples" This reverts commit 94d5e35. * one git automatic merge led to build errors and had to revert several commits * updated samples and added Elements payload after fixing bungled merge * [Designer] Bump Teams to 1.2 * site new card dialog loads template versions now * update stock template * Update dependencies * Npm audit fix * Incorporate changes from main * Merge AAF code into renderer package * removing failing test for now to test AAF publishing * update AC package version to 3.x for AAF testing * Make AdaptiveApplet registries public * Fix new syntax error * New AdaptiveApplet.onExecuteAction event * Add AdaptiveApplet.hostConfig * Allow blocking manual refreshes * Add support for per-action progress indicator * Refactor to make UB model part of main SDK Add support for providing custom SerializationContext to AdaptiveApplet * Some refactoring to support auth model * Package cleanup * More refactoring for auth support * Web Chat support schema 1.3 (#5514) Co-authored-by: Paul Campbell <[email protected]> * Some renaming * Fix weird discrepancy with main * Auth support complete * Add anchor right click support Cleanup * Tweaks Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> * Update Action.Execute.json Update doc URL for Action.Execute * [Shared] 1.4 - Action.Execute (#5539) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * Fix ShouldSerialize Co-authored-by: Rebecca Muraira <[email protected]> * [.NET] Add support for parsing schema 1.4 features (#5531) * [.NET] Add support for parsing schema 1.4 features * PR feedback * PR feedback * [Android] Action.Execute support (#5551) * Fix SWIG ordering * Action.Execute support * Revert ParseUtil::GetValueAsString; not a duplicate * Bump version * [iOS] Action.Execute Changes (#5549) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * [iOS] Action.Execute ios change * [iOS] exposed auth card to the root card * [iOS] fixed typo * added unit tests * [iOS] Added Action.Execute Renderer * [iOS] CR Comments Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [UWP] Add parsing of schema 1.4 changes and Action.Excute support (#5554) * [UWP] Add parsing of schema 1.4 changes and Action.Excute support * Fix SAL Co-authored-by: Joseph Woo <[email protected]> * Add validation + Action.Execute test card * [iOS] updated text view to update its intrinsic content size dynamically (#5560) * [JS] Universal Action designer support + some bug fixes (#5565) * Universal Actions designer support Plus some bug fixes * Cleanup * [JS] Action.description and TextBlock.style * version update for Android * description --> tooltip * Bump custom.props version * [JS] Updated package deps * [JS] Updated package versions * Metrics for layout structure comparison (#5576) * Added bleu score metric collection for layout structure comparions * latest changes based on review comments * removed OrderedDict for sorting * latest changes * command usage changes * [shared] Parser support for TextBlock headings changes (#5577) * [Shared] Text Heading Support * Added Samples * changed spaces to tabs in .json * [iOS] Text heading changes (#5584) * [Shared] Text Heading Support * Added Samples * [iOS] Text heading changes * [Android][Accessibility] TextBlock style: heading (#5587) * [Android] Accessible Headings * Bump to 1.5 * Missed SWIG enum * [UWP][Shared] Implement Text Heading Object model for UWP and fix shared model serialization (#5601) * Remove tooltip implementation * Remove tooltip from schema * Remove tooltip (description) from designer * Restore Action.accessibleTitle * Add TextBlock.headingLevel to HostConfig * HostConfig.textBlock -> HostConfig.headings * Designer fix after rebasing to js-1.5-preview Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Keerthana Manoharan <[email protected]> * Add Action.tooltip * Promote tooltip to aria-label when appropriate Co-authored-by: Robin Liao <[email protected]> Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Keerthana Manoharan <[email protected]>
karthikgopal36
added a commit
that referenced
this pull request
Apr 14, 2021
* [JS] Overflow actions (flyout menu) #4715 (Pre-Release) (#5446) * [JS] Overflow actions #4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * "Mode" property added to AdaptiveCardSchemaKey. Enum created for "Mode" with "Primary" & " Secondary" constants. "Mode" is parsed from the json string. * allowMoreThanMaxActionsInOverflowMenu flag added to HostConfig. If allowMoreThanMaxActionsInOverflowMenu is set, excess buttons will be moved to Overflow, * OverflowAction view is rendered for secondary action elements. BottomSheetDoalog is Integrated and DropdownElement is created. Resource files added for Overflow view & BottomSheetDialog's background. Scheme keys added. IOverllowActionRenderer interface created for customizing the Overflow rendering behavior. * Unit Test "ActionModePropertiesTest.java" added. Method added for custom context menu . Version 1.5 introduced and sample json files added. Additional method added to AdaptiveCardRenderer for customizing OverflowActionRenderer. * IOverflowLayout onRenderOverflowAction callback refactored. OnclickListener added to custom overflow view. * Addressed PR comments. Code formatted. * Addressed PR comments. * Addressed review comments. * rootLevelAction implementation logic is refactored. * IOverflowActionRenderer callback methods refactored. - getRootLevelAction(), shouldDisplayCustomActionMenu() methods removed. * SplitActionMode code moved to AdaptiveCardRenderer. shouldDisplayCustomOverflowActionMenu() added to IOverflowActionRenderer.java rootLevelFlags added to RenderArgs. * PopupWindow is integrated and BottomSheetDialog dependency is removed. Added Java 8 support. IoverflowActionRenderer Callbacks refactored. Swig java object models files committed. PR comments resolved. * Swig files committed. * Addressed PR comments. * Unused files removed. * Java 8 support added to mobileChatApp * Androidx annotation updated. Co-authored-by: David Claux <[email protected]> Co-authored-by: REDMOND\kargopal <[email protected]>
robin-liao
added a commit
that referenced
this pull request
Apr 15, 2021
* [JS] Overflow actions (flyout menu) #4715 (Pre-Release) (#5446) * [JS] Overflow actions #4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * "Mode" property added to AdaptiveCardSchemaKey. Enum created for "Mode" with "Primary" & " Secondary" constants. "Mode" is parsed from the json string. * allowMoreThanMaxActionsInOverflowMenu flag added to HostConfig. If allowMoreThanMaxActionsInOverflowMenu is set, excess buttons will be moved to Overflow, * OverflowAction view is rendered for secondary action elements. BottomSheetDoalog is Integrated and DropdownElement is created. Resource files added for Overflow view & BottomSheetDialog's background. Scheme keys added. IOverllowActionRenderer interface created for customizing the Overflow rendering behavior. * Unit Test "ActionModePropertiesTest.java" added. Method added for custom context menu . Version 1.5 introduced and sample json files added. Additional method added to AdaptiveCardRenderer for customizing OverflowActionRenderer. * IOverflowLayout onRenderOverflowAction callback refactored. OnclickListener added to custom overflow view. * Addressed PR comments. Code formatted. * Addressed PR comments. * Addressed review comments. * rootLevelAction implementation logic is refactored. * IOverflowActionRenderer callback methods refactored. - getRootLevelAction(), shouldDisplayCustomActionMenu() methods removed. * [iOS] [Preview] Overflow Actions * merge * SplitActionMode code moved to AdaptiveCardRenderer. shouldDisplayCustomOverflowActionMenu() added to IOverflowActionRenderer.java rootLevelFlags added to RenderArgs. * update * address PR comments * revert unncessary change * clang-format * clang-format * PopupWindow is integrated and BottomSheetDialog dependency is removed. Added Java 8 support. IoverflowActionRenderer Callbacks refactored. Swig java object models files committed. PR comments resolved. * Swig files committed. * address PR comments * update due to merge * update due to merge * fix due to merge * update callback declaration to conform the spec * minor update * icon image lazy load Co-authored-by: David Claux <[email protected]> Co-authored-by: REDMOND\kargopal <[email protected]>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…#5661) * [JS] Overflow actions (flyout menu) microsoft#4715 (Pre-Release) (microsoft#5446) * [JS] Overflow actions microsoft#4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (microsoft#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * Js/tooltips headings (microsoft#5608) * Schema 1.4 (microsoft#5317) * Schema update for Action.Execute and refresh * Generate 1.4 schema file * Updated specs * Update toc.yml * Updated specs * Add authentication * Updated specs * Fix typos * Add missing Action.Execute.verb * Update verbiage * Add Action.Execute sample * Table of contents updates and labels on the sample inputs Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [JS] Add support for Universal Actions (microsoft#5533) * Work in progress * strictNullChecks, noImplicitAny noImplicitReturns, noImplicitThis, noUnusedLocals noFallthroughCasesInSwitch More refactoring Work in progress * var --> let * Array<type> --> type[] for (let i = 0 ...) --> for (let item of ...) Additional cleanup Work in progress * null --> undefined where appropriate * Code organizing plus some cleanup * CardObject, CardElement, TextBlock now use schema * Image, FactSet now use schema * FactSet fully uses schema * Library size reduction * Looking at decorators... * Fully move to decorators * Some cleanup * selectAction/inlineAction --> schema * ChoiceSet/ToggleInput --> schema * Media -> schema * All inputs --> schema * Fix IE11 compat (don't use obj.constructor.name) * OpenUrl/ToggleVis./Submit -> schema * Action.Http --> schema * Everything now uses schema * Merge changes from master * Fix designer build break * Add version info in type registries Plus some cleanup * Forgot to add v1.2 to ToggleVisibility * API simplification * Library size reduction (~2 KB minified) * Reduce library size * Small simplification * Update README wih notable changes so far * More simplifications * More simplification + 1KB size reduction * More simplification + bug fix * Parse logic refactor (WIP) * Refactor parse logic (WIP) * Move designer off global registry * Small cLeanup * Refactor toJSON * Parse/serialize to/from specific schema version Full version picker support Still WIP, but almost there * Code complete - full version picker support * Fix test case + minor tweak * Designer bug fixes and minor enhancements * Review feedback so far + designer improvements * Designer bug fixes * Add support for cancelling d&d with ESC * Review feedback + fix value type for number input * Address review feedback * More review feedback * Fix Image.Width/Height serialization regression * Fix Action.Submit not incl. empty inputs anymore Add onExecuteAction handler in Preview Mode * Small designer tweak * Small popup control refactor * [Designer] Enhanced data binding support * [Designer] Small tweak/fix * [Designer] Improved sample data support * Use correct sample data in Preview Mode * Integrate changes from master * Add support for "preview" param on designer URL Hide data structure toolbox * [Designer] Enhanced sample picker dialog * Fix integration mistake * [Designer] Combine open sample and new card buttons Also fully remove "full screen" button * Remove references to removed buttons * Sample picker tweaks * Fix nasty regression introduced by fix in master * [Designer] Add CHANGELOG.md * Publishing preview designer + AC JS packages * [Designer] HostContainer controls target version * [Designer] Adding getCard and setCard back * bump package versions for beta release * Update README.md * Improve experience for modern browsers * [Designer] Add modulus, round, ceil, floor func. [Renderer] Serialization bug fixes * Update README * Small cleanup * Work in progress * Work in progress * [Templating] Fix $when not working within loops [Renderer] Dynamically convert values to string for string properties * [Templating] Add toString, parseInt, parseFloat Refactor function storage to avoid name conflicts [Renderer] Revert automatic conversion to string * CLeanup * Work in progress * Work in progress * Work in progress * Small fixes * [Designer] Styling update * [Designer] Styling update * Work in progress * Work in progress * Work in progress * Disable lockDataStructure * Work in progress * Work in progress * Package-lock updates * Work in progress * Move to Adaptive Expression * Cleanup * Templating tweaks + initial doc generation * [Templating] Bug fixes * Add null check for this.renderedElement * updated website pacakge versions. removed const from exported enums * [Templating] Fix regr introduced with last commit Update README.ms * [Templating] Fix broken {{Date}} and {{TIME}} * fix website templating script based on API changes * Changes to accommodate Schema changes (microsoft#3967) * Changes to accommodate Schema changes: * appId property - removed * autoRefresh property - renamed * userIds and displayCardWhenRefresh properties inside refresh - removed * Renamed ActivityInvocationContext.Refresh to ActivityInvocationContext.Automatic * Renamed ActivityInvocationContext as ActivityInvocationTrigger * Moving ActivityInvocationTrigger inside InvokeActivity as per design * Update to use AEL * Better auto refresh handling * update template samples location and where website loads them from * Updated the Scenarios * Fix website - load Monaco before designer init * Update designer README * ported samples updates from .net branch * [Site] Fix data sample not loading * variable misnamed * Add built-in refresh button * Fix data structure gen from null * update site script * Fix duplicated refresh button * Small doc fix * Update to AEL 4.9.0-rc4 * Revert "Update to AEL 4.9.0-rc4" This reverts commit e3a0d77. * Upgrade to AEL 4.9.0-rc5 * Updated samples and added Elements cards * Revert "Merge branch 'ts/renderer-refactor' of github.com:Microsoft/AdaptiveCards into ts/renderer-refactor" This reverts commit 858c7c0, reversing changes made to 7cd9ef6. * Revert "Updated samples and added Elements cards" This reverts commit 7cd9ef6. * Updated Samples * Revert "Updated Samples" This reverts commit 94d5e35. * one git automatic merge led to build errors and had to revert several commits * updated samples and added Elements payload after fixing bungled merge * [Designer] Bump Teams to 1.2 * site new card dialog loads template versions now * update stock template * Update dependencies * Npm audit fix * Incorporate changes from main * Merge AAF code into renderer package * removing failing test for now to test AAF publishing * update AC package version to 3.x for AAF testing * Make AdaptiveApplet registries public * Fix new syntax error * New AdaptiveApplet.onExecuteAction event * Add AdaptiveApplet.hostConfig * Allow blocking manual refreshes * Add support for per-action progress indicator * Refactor to make UB model part of main SDK Add support for providing custom SerializationContext to AdaptiveApplet * Some refactoring to support auth model * Package cleanup * More refactoring for auth support * Web Chat support schema 1.3 (microsoft#5514) Co-authored-by: Paul Campbell <[email protected]> * Some renaming * Fix weird discrepancy with main * Auth support complete * Add anchor right click support Cleanup * Tweaks Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> * Update Action.Execute.json Update doc URL for Action.Execute * [Shared] 1.4 - Action.Execute (microsoft#5539) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * Fix ShouldSerialize Co-authored-by: Rebecca Muraira <[email protected]> * [.NET] Add support for parsing schema 1.4 features (microsoft#5531) * [.NET] Add support for parsing schema 1.4 features * PR feedback * PR feedback * [Android] Action.Execute support (microsoft#5551) * Fix SWIG ordering * Action.Execute support * Revert ParseUtil::GetValueAsString; not a duplicate * Bump version * [iOS] Action.Execute Changes (microsoft#5549) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * [iOS] Action.Execute ios change * [iOS] exposed auth card to the root card * [iOS] fixed typo * added unit tests * [iOS] Added Action.Execute Renderer * [iOS] CR Comments Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [UWP] Add parsing of schema 1.4 changes and Action.Excute support (microsoft#5554) * [UWP] Add parsing of schema 1.4 changes and Action.Excute support * Fix SAL Co-authored-by: Joseph Woo <[email protected]> * Add validation + Action.Execute test card * [iOS] updated text view to update its intrinsic content size dynamically (microsoft#5560) * [JS] Universal Action designer support + some bug fixes (microsoft#5565) * Universal Actions designer support Plus some bug fixes * Cleanup * [JS] Action.description and TextBlock.style * version update for Android * description --> tooltip * Bump custom.props version * [JS] Updated package deps * [JS] Updated package versions * Metrics for layout structure comparison (microsoft#5576) * Added bleu score metric collection for layout structure comparions * latest changes based on review comments * removed OrderedDict for sorting * latest changes * command usage changes * [shared] Parser support for TextBlock headings changes (microsoft#5577) * [Shared] Text Heading Support * Added Samples * changed spaces to tabs in .json * [iOS] Text heading changes (microsoft#5584) * [Shared] Text Heading Support * Added Samples * [iOS] Text heading changes * [Android][Accessibility] TextBlock style: heading (microsoft#5587) * [Android] Accessible Headings * Bump to 1.5 * Missed SWIG enum * [UWP][Shared] Implement Text Heading Object model for UWP and fix shared model serialization (microsoft#5601) * Remove tooltip implementation * Remove tooltip from schema * Remove tooltip (description) from designer Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Keerthana Manoharan <[email protected]> * [JS] TextBlock.style (microsoft#5607) * Schema 1.4 (microsoft#5317) * Schema update for Action.Execute and refresh * Generate 1.4 schema file * Updated specs * Update toc.yml * Updated specs * Add authentication * Updated specs * Fix typos * Add missing Action.Execute.verb * Update verbiage * Add Action.Execute sample * Table of contents updates and labels on the sample inputs Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [JS] Add support for Universal Actions (microsoft#5533) * Work in progress * strictNullChecks, noImplicitAny noImplicitReturns, noImplicitThis, noUnusedLocals noFallthroughCasesInSwitch More refactoring Work in progress * var --> let * Array<type> --> type[] for (let i = 0 ...) --> for (let item of ...) Additional cleanup Work in progress * null --> undefined where appropriate * Code organizing plus some cleanup * CardObject, CardElement, TextBlock now use schema * Image, FactSet now use schema * FactSet fully uses schema * Library size reduction * Looking at decorators... * Fully move to decorators * Some cleanup * selectAction/inlineAction --> schema * ChoiceSet/ToggleInput --> schema * Media -> schema * All inputs --> schema * Fix IE11 compat (don't use obj.constructor.name) * OpenUrl/ToggleVis./Submit -> schema * Action.Http --> schema * Everything now uses schema * Merge changes from master * Fix designer build break * Add version info in type registries Plus some cleanup * Forgot to add v1.2 to ToggleVisibility * API simplification * Library size reduction (~2 KB minified) * Reduce library size * Small simplification * Update README wih notable changes so far * More simplifications * More simplification + 1KB size reduction * More simplification + bug fix * Parse logic refactor (WIP) * Refactor parse logic (WIP) * Move designer off global registry * Small cLeanup * Refactor toJSON * Parse/serialize to/from specific schema version Full version picker support Still WIP, but almost there * Code complete - full version picker support * Fix test case + minor tweak * Designer bug fixes and minor enhancements * Review feedback so far + designer improvements * Designer bug fixes * Add support for cancelling d&d with ESC * Review feedback + fix value type for number input * Address review feedback * More review feedback * Fix Image.Width/Height serialization regression * Fix Action.Submit not incl. empty inputs anymore Add onExecuteAction handler in Preview Mode * Small designer tweak * Small popup control refactor * [Designer] Enhanced data binding support * [Designer] Small tweak/fix * [Designer] Improved sample data support * Use correct sample data in Preview Mode * Integrate changes from master * Add support for "preview" param on designer URL Hide data structure toolbox * [Designer] Enhanced sample picker dialog * Fix integration mistake * [Designer] Combine open sample and new card buttons Also fully remove "full screen" button * Remove references to removed buttons * Sample picker tweaks * Fix nasty regression introduced by fix in master * [Designer] Add CHANGELOG.md * Publishing preview designer + AC JS packages * [Designer] HostContainer controls target version * [Designer] Adding getCard and setCard back * bump package versions for beta release * Update README.md * Improve experience for modern browsers * [Designer] Add modulus, round, ceil, floor func. [Renderer] Serialization bug fixes * Update README * Small cleanup * Work in progress * Work in progress * [Templating] Fix $when not working within loops [Renderer] Dynamically convert values to string for string properties * [Templating] Add toString, parseInt, parseFloat Refactor function storage to avoid name conflicts [Renderer] Revert automatic conversion to string * CLeanup * Work in progress * Work in progress * Work in progress * Small fixes * [Designer] Styling update * [Designer] Styling update * Work in progress * Work in progress * Work in progress * Disable lockDataStructure * Work in progress * Work in progress * Package-lock updates * Work in progress * Move to Adaptive Expression * Cleanup * Templating tweaks + initial doc generation * [Templating] Bug fixes * Add null check for this.renderedElement * updated website pacakge versions. removed const from exported enums * [Templating] Fix regr introduced with last commit Update README.ms * [Templating] Fix broken {{Date}} and {{TIME}} * fix website templating script based on API changes * Changes to accommodate Schema changes (microsoft#3967) * Changes to accommodate Schema changes: * appId property - removed * autoRefresh property - renamed * userIds and displayCardWhenRefresh properties inside refresh - removed * Renamed ActivityInvocationContext.Refresh to ActivityInvocationContext.Automatic * Renamed ActivityInvocationContext as ActivityInvocationTrigger * Moving ActivityInvocationTrigger inside InvokeActivity as per design * Update to use AEL * Better auto refresh handling * update template samples location and where website loads them from * Updated the Scenarios * Fix website - load Monaco before designer init * Update designer README * ported samples updates from .net branch * [Site] Fix data sample not loading * variable misnamed * Add built-in refresh button * Fix data structure gen from null * update site script * Fix duplicated refresh button * Small doc fix * Update to AEL 4.9.0-rc4 * Revert "Update to AEL 4.9.0-rc4" This reverts commit e3a0d77. * Upgrade to AEL 4.9.0-rc5 * Updated samples and added Elements cards * Revert "Merge branch 'ts/renderer-refactor' of github.com:Microsoft/AdaptiveCards into ts/renderer-refactor" This reverts commit 858c7c0, reversing changes made to 7cd9ef6. * Revert "Updated samples and added Elements cards" This reverts commit 7cd9ef6. * Updated Samples * Revert "Updated Samples" This reverts commit 94d5e35. * one git automatic merge led to build errors and had to revert several commits * updated samples and added Elements payload after fixing bungled merge * [Designer] Bump Teams to 1.2 * site new card dialog loads template versions now * update stock template * Update dependencies * Npm audit fix * Incorporate changes from main * Merge AAF code into renderer package * removing failing test for now to test AAF publishing * update AC package version to 3.x for AAF testing * Make AdaptiveApplet registries public * Fix new syntax error * New AdaptiveApplet.onExecuteAction event * Add AdaptiveApplet.hostConfig * Allow blocking manual refreshes * Add support for per-action progress indicator * Refactor to make UB model part of main SDK Add support for providing custom SerializationContext to AdaptiveApplet * Some refactoring to support auth model * Package cleanup * More refactoring for auth support * Web Chat support schema 1.3 (microsoft#5514) Co-authored-by: Paul Campbell <[email protected]> * Some renaming * Fix weird discrepancy with main * Auth support complete * Add anchor right click support Cleanup * Tweaks Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> * Update Action.Execute.json Update doc URL for Action.Execute * [Shared] 1.4 - Action.Execute (microsoft#5539) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * Fix ShouldSerialize Co-authored-by: Rebecca Muraira <[email protected]> * [.NET] Add support for parsing schema 1.4 features (microsoft#5531) * [.NET] Add support for parsing schema 1.4 features * PR feedback * PR feedback * [Android] Action.Execute support (microsoft#5551) * Fix SWIG ordering * Action.Execute support * Revert ParseUtil::GetValueAsString; not a duplicate * Bump version * [iOS] Action.Execute Changes (microsoft#5549) * UAM * moar tests * PR feedback * Add new files to UWP to unbreak build * [iOS] Action.Execute ios change * [iOS] exposed auth card to the root card * [iOS] fixed typo * added unit tests * [iOS] Added Action.Execute Renderer * [iOS] CR Comments Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> * [UWP] Add parsing of schema 1.4 changes and Action.Excute support (microsoft#5554) * [UWP] Add parsing of schema 1.4 changes and Action.Excute support * Fix SAL Co-authored-by: Joseph Woo <[email protected]> * Add validation + Action.Execute test card * [iOS] updated text view to update its intrinsic content size dynamically (microsoft#5560) * [JS] Universal Action designer support + some bug fixes (microsoft#5565) * Universal Actions designer support Plus some bug fixes * Cleanup * [JS] Action.description and TextBlock.style * version update for Android * description --> tooltip * Bump custom.props version * [JS] Updated package deps * [JS] Updated package versions * Metrics for layout structure comparison (microsoft#5576) * Added bleu score metric collection for layout structure comparions * latest changes based on review comments * removed OrderedDict for sorting * latest changes * command usage changes * [shared] Parser support for TextBlock headings changes (microsoft#5577) * [Shared] Text Heading Support * Added Samples * changed spaces to tabs in .json * [iOS] Text heading changes (microsoft#5584) * [Shared] Text Heading Support * Added Samples * [iOS] Text heading changes * [Android][Accessibility] TextBlock style: heading (microsoft#5587) * [Android] Accessible Headings * Bump to 1.5 * Missed SWIG enum * [UWP][Shared] Implement Text Heading Object model for UWP and fix shared model serialization (microsoft#5601) * Remove tooltip implementation * Remove tooltip from schema * Remove tooltip (description) from designer * Restore Action.accessibleTitle * Add TextBlock.headingLevel to HostConfig * HostConfig.textBlock -> HostConfig.headings * Designer fix after rebasing to js-1.5-preview Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Keerthana Manoharan <[email protected]> * Add Action.tooltip * Promote tooltip to aria-label when appropriate Co-authored-by: Robin Liao <[email protected]> Co-authored-by: Adaptive Cards Specs CI <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Rebecca Muraira <[email protected]> Co-authored-by: shalinijoshi19 <[email protected]> Co-authored-by: Matt Hidinger <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: nesalang <[email protected]> Co-authored-by: William Wong <[email protected]> Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Keerthana Manoharan <[email protected]>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [JS] Overflow actions (flyout menu) microsoft#4715 (Pre-Release) (microsoft#5446) * [JS] Overflow actions microsoft#4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (microsoft#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * "Mode" property added to AdaptiveCardSchemaKey. Enum created for "Mode" with "Primary" & " Secondary" constants. "Mode" is parsed from the json string. * allowMoreThanMaxActionsInOverflowMenu flag added to HostConfig. If allowMoreThanMaxActionsInOverflowMenu is set, excess buttons will be moved to Overflow, * OverflowAction view is rendered for secondary action elements. BottomSheetDoalog is Integrated and DropdownElement is created. Resource files added for Overflow view & BottomSheetDialog's background. Scheme keys added. IOverllowActionRenderer interface created for customizing the Overflow rendering behavior. * Unit Test "ActionModePropertiesTest.java" added. Method added for custom context menu . Version 1.5 introduced and sample json files added. Additional method added to AdaptiveCardRenderer for customizing OverflowActionRenderer. * IOverflowLayout onRenderOverflowAction callback refactored. OnclickListener added to custom overflow view. * Addressed PR comments. Code formatted. * Addressed PR comments. * Addressed review comments. * rootLevelAction implementation logic is refactored. * IOverflowActionRenderer callback methods refactored. - getRootLevelAction(), shouldDisplayCustomActionMenu() methods removed. * SplitActionMode code moved to AdaptiveCardRenderer. shouldDisplayCustomOverflowActionMenu() added to IOverflowActionRenderer.java rootLevelFlags added to RenderArgs. * PopupWindow is integrated and BottomSheetDialog dependency is removed. Added Java 8 support. IoverflowActionRenderer Callbacks refactored. Swig java object models files committed. PR comments resolved. * Swig files committed. * Addressed PR comments. * Unused files removed. * Java 8 support added to mobileChatApp * Androidx annotation updated. Co-authored-by: David Claux <[email protected]> Co-authored-by: REDMOND\kargopal <[email protected]>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [JS] Overflow actions (flyout menu) microsoft#4715 (Pre-Release) (microsoft#5446) * [JS] Overflow actions microsoft#4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (microsoft#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * "Mode" property added to AdaptiveCardSchemaKey. Enum created for "Mode" with "Primary" & " Secondary" constants. "Mode" is parsed from the json string. * allowMoreThanMaxActionsInOverflowMenu flag added to HostConfig. If allowMoreThanMaxActionsInOverflowMenu is set, excess buttons will be moved to Overflow, * OverflowAction view is rendered for secondary action elements. BottomSheetDoalog is Integrated and DropdownElement is created. Resource files added for Overflow view & BottomSheetDialog's background. Scheme keys added. IOverllowActionRenderer interface created for customizing the Overflow rendering behavior. * Unit Test "ActionModePropertiesTest.java" added. Method added for custom context menu . Version 1.5 introduced and sample json files added. Additional method added to AdaptiveCardRenderer for customizing OverflowActionRenderer. * IOverflowLayout onRenderOverflowAction callback refactored. OnclickListener added to custom overflow view. * Addressed PR comments. Code formatted. * Addressed PR comments. * Addressed review comments. * rootLevelAction implementation logic is refactored. * IOverflowActionRenderer callback methods refactored. - getRootLevelAction(), shouldDisplayCustomActionMenu() methods removed. * [iOS] [Preview] Overflow Actions * merge * SplitActionMode code moved to AdaptiveCardRenderer. shouldDisplayCustomOverflowActionMenu() added to IOverflowActionRenderer.java rootLevelFlags added to RenderArgs. * update * address PR comments * revert unncessary change * clang-format * clang-format * PopupWindow is integrated and BottomSheetDialog dependency is removed. Added Java 8 support. IoverflowActionRenderer Callbacks refactored. Swig java object models files committed. PR comments resolved. * Swig files committed. * address PR comments * update due to merge * update due to merge * fix due to merge * update callback declaration to conform the spec * minor update * icon image lazy load Co-authored-by: David Claux <[email protected]> Co-authored-by: REDMOND\kargopal <[email protected]>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [JS] Overflow actions (flyout menu) microsoft#4715 (Pre-Release) (microsoft#5446) * [JS] Overflow actions microsoft#4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (microsoft#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * "Mode" property added to AdaptiveCardSchemaKey. Enum created for "Mode" with "Primary" & " Secondary" constants. "Mode" is parsed from the json string. * allowMoreThanMaxActionsInOverflowMenu flag added to HostConfig. If allowMoreThanMaxActionsInOverflowMenu is set, excess buttons will be moved to Overflow, * OverflowAction view is rendered for secondary action elements. BottomSheetDoalog is Integrated and DropdownElement is created. Resource files added for Overflow view & BottomSheetDialog's background. Scheme keys added. IOverllowActionRenderer interface created for customizing the Overflow rendering behavior. * Unit Test "ActionModePropertiesTest.java" added. Method added for custom context menu . Version 1.5 introduced and sample json files added. Additional method added to AdaptiveCardRenderer for customizing OverflowActionRenderer. * IOverflowLayout onRenderOverflowAction callback refactored. OnclickListener added to custom overflow view. * Addressed PR comments. Code formatted. * Addressed PR comments. * Addressed review comments. * rootLevelAction implementation logic is refactored. * IOverflowActionRenderer callback methods refactored. - getRootLevelAction(), shouldDisplayCustomActionMenu() methods removed. * SplitActionMode code moved to AdaptiveCardRenderer. shouldDisplayCustomOverflowActionMenu() added to IOverflowActionRenderer.java rootLevelFlags added to RenderArgs. * PopupWindow is integrated and BottomSheetDialog dependency is removed. Added Java 8 support. IoverflowActionRenderer Callbacks refactored. Swig java object models files committed. PR comments resolved. * Swig files committed. * Addressed PR comments. * Unused files removed. * Java 8 support added to mobileChatApp * Androidx annotation updated. Co-authored-by: David Claux <[email protected]> Co-authored-by: REDMOND\kargopal <[email protected]>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [JS] Overflow actions (flyout menu) microsoft#4715 (Pre-Release) (microsoft#5446) * [JS] Overflow actions microsoft#4715 * use global setting to control exceeding actions * address PR comments * fix PR build * fix PR build * fix PR build * fix pr build * address PR comments * address PR comments Co-authored-by: David Claux <[email protected]> Ignoring unrelated Android check failures * [JS] Action.mode designer support + promote secondary action to primary on execute (microsoft#5449) * Action.mode designer support Promote secondary action to primary on execute * Slight change in behavior for action promotion * Slight refactor * "Mode" property added to AdaptiveCardSchemaKey. Enum created for "Mode" with "Primary" & " Secondary" constants. "Mode" is parsed from the json string. * allowMoreThanMaxActionsInOverflowMenu flag added to HostConfig. If allowMoreThanMaxActionsInOverflowMenu is set, excess buttons will be moved to Overflow, * OverflowAction view is rendered for secondary action elements. BottomSheetDoalog is Integrated and DropdownElement is created. Resource files added for Overflow view & BottomSheetDialog's background. Scheme keys added. IOverllowActionRenderer interface created for customizing the Overflow rendering behavior. * Unit Test "ActionModePropertiesTest.java" added. Method added for custom context menu . Version 1.5 introduced and sample json files added. Additional method added to AdaptiveCardRenderer for customizing OverflowActionRenderer. * IOverflowLayout onRenderOverflowAction callback refactored. OnclickListener added to custom overflow view. * Addressed PR comments. Code formatted. * Addressed PR comments. * Addressed review comments. * rootLevelAction implementation logic is refactored. * IOverflowActionRenderer callback methods refactored. - getRootLevelAction(), shouldDisplayCustomActionMenu() methods removed. * [iOS] [Preview] Overflow Actions * merge * SplitActionMode code moved to AdaptiveCardRenderer. shouldDisplayCustomOverflowActionMenu() added to IOverflowActionRenderer.java rootLevelFlags added to RenderArgs. * update * address PR comments * revert unncessary change * clang-format * clang-format * PopupWindow is integrated and BottomSheetDialog dependency is removed. Added Java 8 support. IoverflowActionRenderer Callbacks refactored. Swig java object models files committed. PR comments resolved. * Swig files committed. * address PR comments * update due to merge * update due to merge * fix due to merge * update callback declaration to conform the spec * minor update * icon image lazy load Co-authored-by: David Claux <[email protected]> Co-authored-by: REDMOND\kargopal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
ActionSet overflow flyout (... actions menu) #4715
Description
To introduce a new feature of overflow actions, the implementation follows the spec:
This new feature will bring as part of Schema version 1.5
Introduce a new property field
mode
to allAction
type. Its value can beprimary
(default) orsecondary
. For allsecondary
action instances in the sameactions
array (either the root levelactions
section orActionSet
inside card elements) they'll group as overflow actions, wrap up within a "..." button and display flyout context menu when user clicks "..." button.Introduce a new global setting flag (schema version-free)
allowMoreThanMaxActionsInOverflowMenu
. By default it'sfalse
, but when it'strue
then the actions exceeding the number defined inhostConfig.actions.maxActions
will be auto wrapped up as overflow actions and "..." button for context menu will be displayed.hostConfig.actions.maxActions
doesn't count "..." button itself.Two client callbacks are added to control overflow button "..." and flyout context menu rendering:
onRenderOverflowActions?: (actions: readonly Action[], isRootLevelActions: boolean) => boolean
actions
are those overflow actions wrapped as flyout menu actions, andisRootLevelActions
indicates if the current "..." overflow action belongs to root levelactions
array. If it'sfalse
then it indicates it'sActionSet
asbody
elements.false
means let SDK continue to render "..." button, whiletrue
informs SDK don't render the current "..." button (which implies client code might grab those flyoutactions
and render / handle overflow actions by itself).onDisplayOverflowActionMenu?: (actions: readonly Action[], target?: HTMLElement) => boolean
actions
are those overflow actions wrapped as flyout menu actions, andtarget
is the HTML element triggered the context menu, which usually is the "..." button. It can be used by client to position the context menu if client wants to render flyout by itself.false
means let SDK continue to render flyout context menu, whiletrue
informs SDK don't render flyout (which implies client code might render context menu by itself).Sample Card
How Verified
How you verified the fix, including one or all of the following:
will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow