Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Display action item text at lower screen widths #5420

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Feb 23, 2021

Related Issue

Fixes VSO 30941092

Description

We have some (presumably) imported CSS that hides our feedback and github icons' text at smaller screen widths. This would make sense from a design perspective if we had more than the two icons. As it is, they both fit fine at smaller widths, so we shouldn't be hiding them.

Before

image

After

image

How Verified

  • local build
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Feb 23, 2021

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 merged commit 881cbab into main Feb 24, 2021
@paulcam206 paulcam206 deleted the paulcam/zoomed-icon-text branch February 24, 2021 20:05
@golddove golddove added this to the 21.02 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants