Jwoo/ios columnsetupdate #5296
Merged
Jwoo/ios columnsetupdate #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expression library rc to 4.11.0 * Add expression library to site footer scripts
With our 20.12 release we are fixing a long running bug, where we were shipping our binary packages under the MIT license inadvertently. The MIT license only applies to open source and not shipping binaries which are now governed by our new End User License Agreement for AdaptiveCards.
…4833) ## Related Issue Fixes #4831 ## Description Avoid NullReferenceException while the enum is null in JSON string 
|
Hi @jwoo-msft. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
paulcam206
requested changes
Jan 21, 2021
ghost
added
the
…iveCards into jwoo/ios-columnsetupdate
paulcam206
approved these changes
Jan 22, 2021
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRContentHoldingUIView.mm
Outdated
Show resolved
Hide resolved
Comment on lines
146
to
147
| } else if (self.imageProperties.acrImageSize == ACRImageSizeStretch && frameSize.width != self.imageProperties.contentSize.width && _imageView.image) { | ||
| if (_imageView.image) { |
There was a problem hiding this comment.
we're checking _imageView.image twice :)
| // apply now if image is ready, otherwise wait until it is loaded | ||
| applyBackgroundImageConstraints(backgroundImage.get(), imgView, img); | ||
| applyBackgroundImageConstraints(backgroundImage.get(), imgView, imgView.image); |
There was a problem hiding this comment.
question here -- is applyBackgroundImageConstraints always passed a UIImageView that has a valid .image? should applyBackgroundImageConstraints just use the image property rather than having it passed in as a parameter?
There was a problem hiding this comment.
your question is a valid one. There is a case SDK can have a UIImageview and UIImage separately, but such cases are rare. I will look into this issue when I refactor the background image rendering which is due soon.
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Updated ImageView constraints * updated intrinsic content size * reverted build optimazation settings * [Site] Fix missing expression library dep (microsoft#5194) * expression library rc to 4.11.0 * Add expression library to site footer scripts * Updating Readme to reflect binary license updates With our 20.12 release we are fixing a long running bug, where we were shipping our binary packages under the MIT license inadvertently. The MIT license only applies to open source and not shipping binaries which are now governed by our new End User License Agreement for AdaptiveCards. * Quick verbiage change in the EULA section * More license terms explanation verbiage * [.Net HTML]fix IgnoreDefaultStringEnumConverter NullReference issue (microsoft#4833) ## Related Issue Fixes microsoft#4831 ## Description Avoid NullReferenceException while the enum is null in JSON string  * columnset alignment to fill, and added spacer for factset * work in progress * work in progress * Mostly work except background images * removed the wrapperview * refactoring * refactoring complete // need unit tests and optimazation * fixed stretch issues * Finished fixing small/medium/large images sizes * Added UnitTests * cleaned up the code * complete * fixed ci failures * revert project file changes * chaged made after review comments Co-authored-by: Risheek Rajolu <[email protected]> Co-authored-by: Shalini Joshi-MSFT <[email protected]> Co-authored-by: Tony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #5096, Fixed #4353, Fixed #3677
Description
Fixed numerous issues with Images. Fixed FactSet stretch issues. Updated the sample app not to render when the table view is in a collapsed state.
Before Fix
After Fix
Before Fix
After Fix
Before Fix
After Fix
Before Fix
After Fix
Before Fix
After Fix
Before Fix
The size of the Image in the center is "stretch"
After Fix
The size of the Image in the center is "stretch"
Before Fix
After Fix
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow