Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Update input ids to be more descriptive to avoid dups #5246

Merged
merged 4 commits into from
Jan 11, 2021
Merged

[Samples] Update input ids to be more descriptive to avoid dups #5246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8fb8ab8
[Samples] Update input ids to be more descriptive to avoid dups
Jan 7, 2021
e2ce3f0
Merge branch 'main' into rebecch/sampleLabels
Jan 7, 2021
bca7beb
Merge branch 'main' into rebecch/sampleLabels
Jan 7, 2021
7fca295
Merge branch 'main' into rebecch/sampleLabels
Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions samples/v1.0/Elements/Input.Text.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
{
"type": "Input.Text",
"id": "input1",
"id": "defaultInputId",
"placeholder": "enter comment",
"maxLength": 500
},
Expand All @@ -19,7 +19,7 @@
},
{
"type": "Input.Text",
"id": "input2",
"id": "multilineInputId",
"placeholder": "enter comment",
"maxLength": 500,
"isMultiline": true
Expand All @@ -30,7 +30,7 @@
},
{
"type": "Input.Text",
"id": "input3",
"id": "prefilledInputId",
"placeholder": "enter comment",
"maxLength": 500,
"isMultiline": true,
Expand Down
4 changes: 2 additions & 2 deletions samples/v1.2/Elements/Input.Text.InlineAction.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
{
"type": "Input.Text",
"id": "input1",
"id": "iconInlineActionId",
"inlineAction": {
"type": "Action.Submit",
"iconUrl": "https://adaptivecards.io/content/send.png",
Expand All @@ -23,7 +23,7 @@
},
{
"type": "Input.Text",
"id": "input2",
"id": "textInlineActionId",
"inlineAction": {
"type": "Action.OpenUrl",
"title": "Reply",
Expand Down
6 changes: 3 additions & 3 deletions samples/v1.3/Elements/Input.ChoiceSet.ErrorMessage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"body": [
{
"type": "Input.ChoiceSet",
"id": "input1",
"id": "requiredCompactId",
"style": "compact",
"isMultiSelect": false,
"label": "Required Input.ChoiceSet label (compact)",
Expand All @@ -25,7 +25,7 @@
},
{
"type": "Input.ChoiceSet",
"id": "input2",
"id": "requiredExpandedId",
"style": "expanded",
"isMultiSelect": false,
"label": "Required Input.ChoiceSet label (expanded)",
Expand All @@ -44,7 +44,7 @@
},
{
"type": "Input.ChoiceSet",
"id": "input3",
"id": "requiredMultiselectId",
"style": "expanded",
"isMultiSelect": true,
"label": "Required Input.ChoiceSet label (expanded, multiselect)",
Expand Down
4 changes: 2 additions & 2 deletions samples/v1.3/Elements/Input.Date.Label.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"body": [
{
"type": "Input.Date",
"id": "input1",
"id": "dateLabelId",
"label": "Default Input.Date label"
},
{
"type": "Input.Date",
"id": "input2",
"id": "requiredDateLabelId",
"label": "Required Input.Date label",
"isRequired": true,
"errorMessage": "Required input"
Expand Down
4 changes: 2 additions & 2 deletions samples/v1.3/Elements/Input.Number.Label.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"body": [
{
"type": "Input.Number",
"id": "input1",
"id": "numberLabelId",
"label": "Default Input.Number label"
},
{
"type": "Input.Number",
"id": "input2",
"id": "requiredNumberLabelId",
"label": "Require Input.Number label",
"isRequired": true,
"errorMessage": "Required input"
Expand Down
4 changes: 2 additions & 2 deletions samples/v1.3/Elements/Input.Text.Label.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
"body": [
{
"type": "Input.Text",
"id": "input1",
"id": "textLabelId",
"style": "text",
"label": "Default Input.Text label"
},
{
"type": "Input.Text",
"id": "input2",
"id": "requiredTextLabelId",
"style": "text",
"label": "Required Input.Text label",
"isRequired": true,
Expand Down
4 changes: 2 additions & 2 deletions samples/v1.3/Elements/Input.Time.Label.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"body": [
{
"type": "Input.Time",
"id": "input1",
"id": "timeLabelId",
"label": "Default Input.Time label"
},
{
"type": "Input.Time",
"id": "input2",
"id": "requiredTimeLabelId",
"label": "Required Input.Time label",
"isRequired": true,
"errorMessage": "Required input"
Expand Down
4 changes: 2 additions & 2 deletions samples/v1.3/Elements/Input.Toggle.Label.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"body": [
{
"type": "Input.Toggle",
"id": "input1",
"id": "toggleLabelId",
"title": "I accept the terms and agreements",
"value": "false",
"valueOn": "true",
Expand All @@ -14,7 +14,7 @@
},
{
"type": "Input.Toggle",
"id": "input2",
"id": "requiredToggleLabelId",
"title": "I accept the terms and agreements",
"value": "false",
"valueOn": "true",
Expand Down