Updated IntrinsicContentSize for ImageView #5195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @jwoo-msft; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #5096
Description
IntrinsicContentSize for auto doesn't get the right size until an image is loaded. When the image is loaded, the size is invalidated, and the size should be updated, but with the optimization setting mentioned in the issue. This wasn't working when the actual image is smaller than the initially given size. so updated the initialize image size to zero to force the intrinsic content size update.
Sample Card
Used the payload included in #5096. Doesn't need to update our samples, as the card is similar to our Agenda card in samples/v1.2/Scenario
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow